Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Issue-1429] Resolve Bug for Mention Suggestion Clicks Overwriting Text #1440

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

nickbely-novata
Copy link

Resolved the following issue: #1429.

Root Cause: Clicks on the suggestion dropdown menu forcibly change the anchorOffset and focusOffset position of the cursor.

Resolved by:

  • Establishing the mentionIndex prior to the click taking place, and passing it into the addMention function.

This was the optimal quick solution for now since stopping click event propagation or preventing default click behavior did not prevent the cursor position from updating.

Any expediency with reviewing and merging this bug fix would be appreciated, @jpuri.

@lifemixture
Copy link

lifemixture commented Oct 31, 2024

Also encounter this issue. It works in case you use keyboard to select a person and then press enter key. But it doesn't when you use mouse...

This request should be merged

@lifemixture
Copy link

@jpuri is this possible to merge this?

@Bogdan-Moskovchenko
Copy link

@jpuri it would be great if it can be merged asap. Also encounered this issue

@nickbely-novata
Copy link
Author

I wouldn't count on it, the repo owner hasn't merged anything in over a year. Your best bets are to fork it with the fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants