-
Notifications
You must be signed in to change notification settings - Fork 226
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Typed declarations. #112
Conversation
|
||
public struct ObjCDeclaration: DeclarationType { | ||
public let language: Language = .Swift | ||
public let kind: ObjCDeclarationKind? // FIXME: Type 'ObjCDeclaration' does not conform to protocol 'DeclarationType' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is because the expected type here DeclarationKindType
.
let end = SourceLocation.init(file: file, line: line, column: column, offset: parsedScopeEnd) | ||
extent = (start: start, end: end) | ||
} | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not entirely sure that this is the right thing to do here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FWIW .map(UInt32.init)
didn't work here ¯_(ツ)_/¯
@jpsim any more thoughts on this since we last spoke? Would love to keep moving forward if we can. |
Yes, sorry for the delay. What about our conversation about having a single |
I'll try something to that effect later tonight. |
I took a shot at this in paulyoung#2. |
We'll probably never revive this as-is, closing. #428 shows promise though and is along these lines. Thanks anyway Paul! |
This relates to #87.
I've added
FIXME
s where I ran into hurdles that didn't have an easy immediate fix (or I wasn't sure what to do) just to get something started.