Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean up testing vs linting concepts, plus misc fixes. #124

Merged
merged 2 commits into from
May 20, 2020
Merged

Clean up testing vs linting concepts, plus misc fixes. #124

merged 2 commits into from
May 20, 2020
+101 −70

Conversation

ceball
Copy link
Collaborator

@ceball ceball commented May 20, 2020

Fix #109:

  • Remove "coverage" as a concept from nbcelltests.lint.
  • Remove "lines_per_cell", "cells_per_notebook", "function_definitions", "class_definitions" as concepts from nbcelltests.test.

Fix #120: test.runWith*() fns were not applying any rules. Also, add some basic/beginning testing of test.runWith()* fns (but see #122)

Also:

This was linked to issues May 20, 2020
Clarify what is linting and what is testing #109
Closed
Rules are not being applied by most test functions #120
Closed
@ceball ceball requested a review from vidartf May 20, 2020 10:14
vidartf
vidartf approved these changes May 20, 2020
View reviewed changes
nbcelltests/tests/test_test.py Show resolved Hide resolved
@ceball ceball merged commit b609866 into jpmorganchase:coverage_fixups May 20, 2020
This was referenced May 20, 2020
Closed
Closed
Merged
@ceball ceball deleted the clarify_test_and_lint branch May 20, 2020 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vidartf vidartf vidartf approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Rules are not being applied by most test functions Clarify what is linting and what is testing
2 participants
@ceball @vidartf