Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade TS #683

Merged
merged 1 commit into from
Nov 6, 2024
Merged

Upgrade TS #683

merged 1 commit into from
Nov 6, 2024

Conversation

joshwooding
Copy link
Contributor

No description provided.

@joshwooding joshwooding requested a review from a team as a code owner November 6, 2024 18:21
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Nov 6, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: 121e324

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel Vercel
Copy link

vercel bot commented Nov 6, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
mosaic ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 6, 2024 6:31pm

joshwooding
joshwooding commented Nov 6, 2024
View reviewed changes
packages/core/src/filesystems/RestrictedVolume.ts
@@ -8,19 +8,19 @@ import ImmutableFileSystem from './ImmutableVolume.js';
*/
class RestrictedVolume extends ImmutableFileSystem implements IVolumePartiallyMutable {
#vfs: IFileAccess;
declare promises: any;
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The types are really messed up here

joshwooding
joshwooding commented Nov 6, 2024
View reviewed changes
packages/site-components/src/SearchInput/Results.tsx
const handleKeySelection = e => {
if (e.keyCode === (13 || 32)) {
const handleKeySelection = (e: KeyboardEvent) => {
if (e.key === 'Enter' || e.key === 'Space') {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should improve things

joshwooding
joshwooding commented Nov 6, 2024
View reviewed changes
packages/site-middleware/src/withMDXContent.ts
@@ -87,7 +87,7 @@ export const withMDXContent: MosaicMiddleware<ContentProps> = async (
context: GetServerSidePropsContext
) => {
const { resolvedUrl } = context;
const mosaicMode = context.res.getHeader('X-Mosaic-Mode' || 'active') as MosaicMode;
const mosaicMode = (context.res.getHeader('X-Mosaic-Mode') || 'active') as MosaicMode;
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Another TS flagged issue

@joshwooding joshwooding merged commit 3bb6613 into main Nov 6, 2024
8 checks passed
@joshwooding joshwooding deleted the upgrade-ts branch November 6, 2024 19:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mark-tate mark-tate mark-tate approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@joshwooding @mark-tate