Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added mass #1104

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

Added mass #1104

wants to merge 6 commits into from

Conversation

strikersix23
Copy link

Added mass to vfs, unsure if its correct buts its worth a shot

@jpd002
Copy link
Owner

jpd002 commented Jul 14, 2021

Hey!

You're missing the registration of "mass" in here: https://github.com/jpd002/Play-/blob/master/Source/PS2VM.cpp#L432.

Otherwise, even though it's not a built-in feature in the PS2 (it's implemented by custom modules), I think it works, not really planning on emulating USB storage devices.

@strikersix23
Copy link
Author

strikersix23 commented Jul 14, 2021

Added

@jpd002
Copy link
Owner

jpd002 commented Jul 21, 2021

Thanks! I think something went wrong when you did your change, the PS2VM.cpp file is now completely changed. Could you redo your change to make sure that the diff only includes your additions?

@strikersix23
Copy link
Author

Id just need to rebase

@strikersix23
Copy link
Author

Rebase is done

@strikersix23
Copy link
Author

Im having a problem trying to just show the changes

@Zer0xFF
Copy link
Contributor

Zer0xFF commented Jul 21, 2021

  1. rebasing won't fix this, the commit needs to be redone.
  2. this is very likely happening because you changed git default line ending handling
  3. I remember messing with mass a while back, I don't recall finding any homebrew that works with just these changes (if you have an example that this works with please mention it)

@uyjulian
Copy link

You may need to implement the rename IOCTL for rename support to work properly, since the homebrew usbhdfsd doesn't use iomanX.

@strikersix23
Copy link
Author

strikersix23 commented Jul 21, 2021

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants