Persist framebuffer backing CLUT data to GS memory #1075
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kernle32dll
changed the title
|
Master: PR: |
jpd002
reviewed
Jun 4, 2021
jpd002
reviewed
Jun 4, 2021
kernle32dll
force-pushed
the
framebuffer-clut-2
branch
2 times, most recently
from
ee616e0
to
a4c484a
Compare
|
Is Vulkan supported on android? |
kernle32dll
force-pushed
the
framebuffer-clut-2
branch
2 times, most recently
from
871f747
to
d9c9be9
Compare
|
Any updates about this? |
kernle32dll
force-pushed
the
framebuffer-clut-2
branch
from
d9c9be9
to
5a32f9e
Compare
Required by DBZ Budokai Tenkaichi 2 for CLUT rendering of characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dragonball Z Tenkaichi 2 renders its CLUT information into a framebuffer, and then tries to use it from there. This works for Vulkan, but for OpenGL the framebuffer content is never propagated back into the GS RAM, and thus unavailable when the CLUT information is required.
This PR uses a light-weight approach of reading framebuffer contents when required for CLUT calculation, and persists it (if not already done so). This works pretty well, and only decreases performance marginally.
Special note on the "downSample" part. For whatever reason, on resolution upscaling > 1 I got artifacts in the CLUT rendering. I don't know why, but down-sampling it in GPU memory again helped clear the issues.