Skip to content
This repository has been archived by the owner on Oct 3, 2018. It is now read-only.

Failing test for multiple smiley emoticon #62

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

leoasis
Copy link
Contributor

@leoasis leoasis commented Sep 22, 2014

This is a failing test case for #48

As said there, the problem is that the named emoji pattern matches :D: but it's not a valid emoji, and then the correct smiley pattern is not tested.

@hassankhan
Copy link
Contributor

Haha the test name is really funny

@trevorah
Copy link

Looks like @leoasis is right, we should be able to fix this by making sure we match :D etc before :([a-z0-9A-Z_-]+):, which will swallow up everything.

@hassankhan
Copy link
Contributor

Do you think you could maybe give it a go @trevorah?

@trevorah
Copy link

Yep, it just requires a little bit of time as npm test doesnt give the best output if things error out.

@hassankhan
Copy link
Contributor

Awesome, thanks! 😄

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants