Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nlbwmon: fix db cleanup #44

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

feckert
Copy link

@feckert feckert commented Mar 1, 2021

@jow- The database will only be cleaned up when the daemon is restarted. With
this change, each refresh of the database checks whether the artifacts
should be cleaned up from the past database. Thus, no more than
configured are kept.

This fixes openwrt/packages#14297

@jow-
Copy link
Owner

jow- commented Mar 1, 2021

You should only call database_cleanup() if the earlier database_archive() returned -ESTALE, only then there's anything to potentially clean up.

The database will only be cleaned up when the daemon is restarted. With
this change, each refresh of the database checks whether the artifacts
should be cleaned up from the past database. Thus, no more than
configured are kept.

Signed-off-by: Florian Eckert <[email protected]>
@feckert feckert force-pushed the pr/20210301-fix-db-cleanup branch from 5d91e8f to 5adf900 Compare March 2, 2021 11:21
@feckert
Copy link
Author

feckert commented Apr 20, 2021

@jow- ping

@schuettecarsten
Copy link

@jow- ping... :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

nlbwmon: database files only delete on service restart
3 participants