Test random string generator

Signed-off-by: Jo Vandeginste <[email protected]>

pkg/util/random.go

@@ -7,21 +7,6 @@ import (
 
 const letters = "0123456789ABCDEFGHIJKLMNOPQRSTUVWXYZabcdefghijklmnopqrstuvwxyz-"
 
-// GenerateRandomBytes returns securely generated random bytes.
-// It will return an error if the system's secure random
-// number generator fails to function correctly, in which
-// case the caller should not continue.
-func GenerateRandomBytes(n int) ([]byte, error) {
-	b := make([]byte, n)
-
-	// Note that err == nil only if we read len(b) bytes.
-	if _, err := rand.Read(b); err != nil {
-		return nil, err
-	}
-
-	return b, nil
-}
-
 // GenerateRandomString returns a securely generated random string.
 // It will return an error if the system's secure random
 // number generator fails to function correctly, in which

pkg/util/random_test.go

@@ -0,0 +1,30 @@
+package util
+
+import (
+	"testing"
+
+	"github.com/stretchr/testify/assert"
+	"github.com/stretchr/testify/require"
+)
+
+func TestGenerateRandomString(t *testing.T) {
+	for _, l := range []int{
+		4, 8, 16, 32,
+	} {
+		s, err := GenerateRandomString(l)
+		require.NoError(t, err)
+		assert.Len(t, s, l)
+	}
+}
+
+func TestGenerateRandomStringIsRandom(t *testing.T) {
+	s1, err := GenerateRandomString(32)
+	require.NoError(t, err)
+
+	for i := 0; i < 100; i++ {
+		s2, err := GenerateRandomString(32)
+		require.NoError(t, err)
+
+		assert.NotEqual(t, s1, s2)
+	}
+}