dependency: replace js-sha3 to noble hashes #35
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paulmillr
reviewed
Apr 7, 2024
|
|
||
| /** | ||
| * Keccak256 hash | ||
| * @param data The data | ||
| */ | ||
| export function keccak256(data: string | ArrayLike<number>): string { | ||
| return '0x' + sha3.keccak_256(toByteArray(data)); | ||
| return bytesToHex(keccak_256(toByteArray(data))); |
There was a problem hiding this comment.
Bytes to hex already does that
There was a problem hiding this comment.
ethereum-bloom-filters/src/utils.ts
Line 37 in 163da5e
|
fix 0x and looks good! |
Cool replied to that comment it does do it lower down, if looks good will merge and deploy tomorrow |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
replace js-sha3 to noble hashes as that is a more mature and actively funded repo
tests all pass
requested on issue > #34