Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix issue where workflows don't appear in PRs #110

Merged
merged 3 commits into from
Sep 15, 2024
Merged

Fix issue where workflows don't appear in PRs #110

merged 3 commits into from
Sep 15, 2024

Conversation

josh-wong
Copy link
Owner

@josh-wong josh-wong commented Sep 15, 2024 •
edited
Loading

Description

This PR attempts to fix an issue where other workflows don't appear in PRs when the workflow for checking the PR checklist runs.

Related issues and/or PRs

Changes made

  • Added github.ref to concurrency.

Checklist

The following is a best-effort checklist. If any items in this checklist aren't applicable to this PR, add N/A after each item.

Documentation

  • I have updated the side navigation as necessary. N/A
  • I have updated the documentation to reflect the changes. N/A
  • I have documented or updated any remaining open issues linked to this PR in GitHub, Obsidian, etc.

Build, deploy, and test

  • I have merged and published any dependent changes in other PRs.
  • I have commented my code, particularly in hard-to-understand areas. N/A
  • I have checked that my changes look as expected on a locally built version of the docs site. N/A
  • My changes generate no new warnings.

@josh-wong josh-wong added the bugfix Bug is fixed label Sep 15, 2024
@josh-wong josh-wong self-assigned this Sep 15, 2024
@github-actions GitHub Actions
Copy link
Contributor

@josh-wong Not all items in the checklist have been checked👀

Please review the unchecked items in the PR description.

@josh-wong josh-wong linked an issue Sep 15, 2024 that may be closed by this pull request
Test deployment workflow no longer runs in PRs #102
Open
@github-actions GitHub Actions
Copy link
Contributor

All items in the checklist have been checked🎉

@josh-wong josh-wong merged commit 63fe106 into main Sep 15, 2024
1 of 3 checks passed
@josh-wong josh-wong deleted the fix-workflow-cancellations branch September 15, 2024 07:01
@josh-wong josh-wong mentioned this pull request Sep 15, 2024
Open
josh-wong added a commit that referenced this pull request Sep 19, 2024
@josh-wong
Squashed commit of the following:
c4beedf 
commit 0998ff6
Author: Josh Wong <[email protected]>
Date:   Thu Sep 19 01:20:19 2024 +0900

    Add support for 360-degree images (#112)

    * Add `@photo-sphere-viewer/core` and dependencies

    * Create Image360Viewer.js

commit 03a9228
Author: Josh Wong <[email protected]>
Date:   Mon Sep 16 18:20:48 2024 +0900

    Update announcement bar to promote Baird beer quadrants and experimental AI chatbot (#111)

    * Update announcement bar

    Change the announcement bar from promoting passGen 3.4 to promoting the Baird beer profile quadrants and AI chatbot.

    * Change icon in label in dropdown

    * Test; will revert

    * Revert "Test; will revert"

    This reverts commit 45a4b75.

    * Test; will revert

    * Revert "Test; will revert"

    This reverts commit 5d7e43b.

    * Test; will revert

    * Revert "Test; will revert"

    This reverts commit 151d341.

    * Revert "Update test-deploy.yml"

    This reverts commit fd25fb6.

    * Test; will revert

    * Revert "Test; will revert"

    This reverts commit d8b5be5.

    * Update index.mdx

commit fd25fb6
Author: Josh Wong <[email protected]>
Date:   Mon Sep 16 17:44:23 2024 +0900

    Update test-deploy.yml

commit 61298c0
Author: Josh Wong <[email protected]>
Date:   Sun Sep 15 16:05:36 2024 +0900

    Fix vulnerabilities related to `path-to-regexp` (#108)

commit 63fe106
Author: Josh Wong <[email protected]>
Date:   Sun Sep 15 16:01:39 2024 +0900

    Fix issue where workflows don't appear in PRs (#110)

    * Add `github.ref ` to `concurrency`

    * Add `github.ref ` to `concurrency`

commit 2de2e76
Author: Josh Wong <[email protected]>
Date:   Sun Sep 15 15:39:53 2024 +0900

    Revert "Add feature to run recently queued PR checklist-checking workflow onl…" (#109)

    This reverts commit f0511ca.

commit 1010394
Author: Josh Wong <[email protected]>
Date:   Sun Sep 15 15:12:17 2024 +0900

    Revert "Fix vulnerability"

    This reverts commit 351ce60.

commit 351ce60
Author: Josh Wong <[email protected]>
Date:   Sun Sep 15 15:07:51 2024 +0900

    Fix vulnerability

commit 7450f94
Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Date:   Sat Sep 14 18:01:32 2024 +0900

    Bump send and express (#104)

commit 800dd75
Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Date:   Sat Sep 14 18:00:46 2024 +0900

    Bump body-parser and express (#105)

commit f0511ca
Author: Josh Wong <[email protected]>
Date:   Sat Sep 14 17:45:44 2024 +0900

    Add feature to run recently queued PR checklist-checking workflow only (#103)

    * Fix punctuation

    * Cancel only other checklist-checking jobs

    * Remove fix implemented in #101

commit 4998ad0
Author: Josh Wong <[email protected]>
Date:   Sun Sep 8 23:54:45 2024 +0900

    Change `portfolio` wording and navigation to `projects` (#100)

    * Move file

    * Remove file

    * Rename portfolio to projects

    * Fix links

commit 6fd8ade
Author: Josh Wong <[email protected]>
Date:   Sun Sep 8 23:50:01 2024 +0900

    Add trigger to run after PR checklist checker job (#101)

commit 8f188ab
Merge: 0401216 06cc28b
Author: Josh Wong <[email protected]>
Date:   Sun Sep 8 22:32:48 2024 +0900

    Merge branch 'main' of https://github.com/josh-wong/josh-wong.github.io

commit 0401216
Author: Josh Wong <[email protected]>
Date:   Sun Sep 8 22:18:51 2024 +0900

    Comment our `to` or portfolio dropdown

commit 06cc28b
Author: Josh Wong <[email protected]>
Date:   Sun Sep 8 22:18:51 2024 +0900

    Remove `/` from `routeBasePath`

commit 8ad33e7
Author: Josh Wong <[email protected]>
Date:   Sun Sep 8 22:03:28 2024 +0900

    Add component for unofficial Baird beer chatbot (#98)

    * Create _baird-beer-chatbot.mdx

    * Add link to chatbot

commit c1c34b4
Author: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Date:   Sun Sep 8 19:34:39 2024 +0900

    AUTO: Sync baird-beer-quadrants docs to personal site (#97)

    Co-authored-by: josh-wong <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@josh-wong josh-wong

Labels
bugfix Bug is fixed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Test deployment workflow no longer runs in PRs
1 participant
@josh-wong