Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test deployment workflow no longer runs in PRs #102

Open
josh-wong opened this issue Sep 8, 2024 · 2 comments · Fixed by #110
Open

Test deployment workflow no longer runs in PRs #102

josh-wong opened this issue Sep 8, 2024 · 2 comments · Fixed by #110
Assignees
Labels
bug Something isn't working

Comments

@josh-wong
Copy link
Owner

Issue

After introducing the PR checklist checker workflow in #96, the Test deployment workflow wasn't running. This was because the PR checklist checker workflow is configured to cancel jobs in progress.

After trying to implement a fix in #101, I got the workflow to run after the PR checklist checker workflow runs, but it seems to run on the main branch instead of the PR branch, according to the Actions tab. In addition, the workflow doesn't show as running in the PR.

Potential fix

Add a configuration in the Test deployment workflow to show the workflow running in the PR.

@josh-wong josh-wong added the bug Something isn't working label Sep 8, 2024
@josh-wong josh-wong self-assigned this Sep 8, 2024
@josh-wong
Copy link
Owner Author

Tried to fix this issue in #103, but now the workflow for testing deployments doesn't run again.

@josh-wong josh-wong linked a pull request Sep 15, 2024 that will close this issue
7 tasks
@josh-wong josh-wong reopened this Sep 15, 2024
@josh-wong
Copy link
Owner Author

Keeping this issue open until I can confirm that the fix in #110 works as expected.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant