Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Crypto List): Refreshable crypto list #4

Merged
merged 7 commits into from
Jun 8, 2024

Conversation

josetorronteras
Copy link
Owner

@josetorronteras josetorronteras commented May 29, 2024

CHANGELOG

  • Add error alert
  • Add loading view
  • Add refresh list

@josetorronteras josetorronteras changed the title feat(Crypto List): Feat refreshable crypto list feat(Crypto List): Refreshable crypto list May 29, 2024
@josetorronteras josetorronteras self-assigned this May 29, 2024
@josetorronteras josetorronteras added the enhancement New feature or request label May 29, 2024
Copy link

codecov bot commented Jun 5, 2024

Codecov Report

Attention: Patch coverage is 68.96552% with 9 lines in your changes missing coverage. Please review.

Project coverage is 91.55%. Comparing base (2ea3ba6) to head (df5dbbd).

Files Patch % Lines
CryptoWidgetKitApp/ContentView.swift 55.55% 8 Missing ⚠️
...ryptoWidgetKitApp/ViewModels/CryptoViewModel.swift 90.90% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main       #4      +/-   ##
==========================================
- Coverage   96.82%   91.55%   -5.27%     
==========================================
  Files          10       10              
  Lines         126      154      +28     
==========================================
+ Hits          122      141      +19     
- Misses          4       13       +9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@josetorronteras josetorronteras merged commit 904d37a into main Jun 8, 2024
4 checks passed
@josetorronteras josetorronteras deleted the feat-refreshable-crypto-list branch June 8, 2024 08:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant