Skip to content
This repository has been archived by the owner on Feb 10, 2021. It is now read-only.

Implements refresh token behaviour #244

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

mcarrolle
Copy link

This improvements relates to this issue #57

I create a method refresh which contains the logic to perform a refresh token action. I implement only for GoogleAuthProvider. I modify PlayAuthenticate.isLoggedIn method to launch the refresh token action when the current token is expired.

@joscha
Copy link
Owner

joscha commented Feb 12, 2015

@mcarrolle nice, however storing and reading from the cache is not the best idea unfortunately, it already causes a lot of problems in the connection/link process and that is only a few minutes. Can we think of a different way of storing it?

@mcarrolle
Copy link
Author

Yes you are right. Refresh token need to be stored in reliable storage like database. I am going to add two method (getRefreshToken and saveRefreshToken) in the UserService interface. Is it OK for you ?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants