🧪🔧 Switch to using pypa/build in CI
#463
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch switches the CI/CD workflows to use the PyPA-endorsed PEP 517 build front-end called `build`. It is called without `--sdist` and `--wheel` CLI options, in which case `build` creates an sdist from the Git checkout but the following wheel build is made from that sdist tarball as opposed to using the Git checkout. This has a side effect of smoke-testing that it's possible to build wheels from the published sdists. And this is the flow that `pip install` follows when it's requested to install from an sdist. Ref: jorisroovers#460 (comment)
sigmavirus24
approved these changes
Mar 10, 2023
|
Thanks! |
Merged
jorisroovers
added a commit
that referenced
this pull request
Mar 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch switches the CI/CD workflows to use the PyPA-endorsed PEP 517 build front-end called
build. It is called without--sdistand--wheelCLI options, in which casebuildcreates an sdist from the Git checkout but the following wheel build is made from that sdist tarball as opposed to using the Git checkout.This has a side effect of smoke-testing that it's possible to build wheels from the published sdists. And this is the flow that
pip installfollows when it's requested to install from an sdist.Ref: #460 (comment)