chore: remove limits for admins

README.md

@@ -39,7 +39,6 @@ To configure your Ubiquibot to run this plugin, add the following to the `.ubiqu
     reviewDelayTolerance: "3 Days"
     taskStaleTimeoutDuration: "30 Days"
     maxConcurrentTasks: # Default concurrent task limits per role.
-      admin: 10
       member: 5
       contributor: 3
     startRequiresWallet: true # default is true

src/types/plugin-input.ts

@@ -16,7 +16,7 @@ export const startStopSchema = T.Object(
     reviewDelayTolerance: T.String({ default: "1 Day" }),
     taskStaleTimeoutDuration: T.String({ default: "30 Days" }),
     startRequiresWallet: T.Boolean({ default: true }),
-    maxConcurrentTasks: T.Record(T.String(), T.Integer(), { default: { admin: 20, member: 10, contributor: 2 } }),
+    maxConcurrentTasks: T.Record(T.String(), T.Integer(), { default: { admin: Infinity, member: 10, contributor: 2 } }),
     emptyWalletText: T.String({ default: "Please set your wallet address with the /wallet command first and try again." }),
   },
   {

tests/main.test.ts

@@ -202,21 +202,6 @@ describe("User start/stop", () => {
     expect(memberLimit).toEqual(6);
   });
 
-  test("should set maxLimits to 8 if the user is an admin", async () => {
-    const issue = db.issue.findFirst({ where: { id: { equals: 1 } } }) as unknown as Issue;
-    const sender = db.users.findFirst({ where: { id: { equals: 1 } } }) as unknown as Sender;
-
-    const adminLimit = maxConcurrentDefaults.admin;
-
-    createIssuesForMaxAssignment(adminLimit + 4, sender.id);
-    const context = createContext(issue, sender) as unknown as Context;
-
-    context.adapters = createAdapters(getSupabase(), context as unknown as Context);
-    await expect(userStartStop(context)).rejects.toThrow("You have reached your max task limit. Please close out some tasks before assigning new ones.");
-
-    expect(adminLimit).toEqual(8);
-  });
-
   test("User can't start an issue if they have previously been unassigned by an admin", async () => {
     const issue = db.issue.findFirst({ where: { id: { equals: 6 } } }) as unknown as Issue;
     const sender = db.users.findFirst({ where: { id: { equals: 2 } } }) as unknown as PayloadSender;
@@ -587,7 +572,7 @@ function createIssuesForMaxAssignment(n: number, userId: number) {
 }
 
 const maxConcurrentDefaults = {
-  admin: 8,
+  admin: Infinity,
   member: 6,
   contributor: 4,
 };