Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

svgbob #211

Closed
wants to merge 1 commit into from
Closed

Conversation

elasticdotventures
Copy link

Close # ...

Changes proposed in this pull request:
...

I'm not at all sure if I've done this correctly. This syntax is very odd to me.

Please check...

  • [x ] Files are formated with prettier
  • [ x] New code is covered with unittests
  • [ x] All unittests are passing
  • [ x] All commits are semantic

@jontze
Copy link
Owner

jontze commented Jun 12, 2022

Hey @elasticdotventures , thanks for your contribution and the feature request. The PR is code wise on a good way.

The actions relies on pre-compiled binaries that the project owner of a plugin attach as artifacts to the github releases. And while looking through the releases of the boozook/mdbook-svgbob repo I realized that there is only a single pre-release published (with pre-compiled binaries as artifacts). Sadly the action doesn't support pre-releases yet and therefore the implementation will not work atm, as there is only one release and that's a pre-release.

So I suggest that we create a feature request issue to add support for the svgbob mdbook plugin and another feature request to allow the usage pre-releases of plugins, as this will add some more input variables (probably for each plugin) to the action.

Another approach would be to encourage the author of the boozook/mdbook-svgbob project to publish a stable release on github, what would save us to implement support for unstable releases.

@jontze
Copy link
Owner

jontze commented Dec 7, 2022

I'm closing this PR in favor of #299 and #298.

@jontze jontze closed this Dec 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants