Build prompt when necessary #193
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to HEAVILY improve performance by running the "build" portion of the prompt only when necessary.
Before, the script checked for colors, shell, and many commands on every prompt. Now, we build the prompt only after it is updated.
Now, a few things about this PR:
Overall, I didn't find a way to "benchmark" this. I had been running a personal, heavily modified version of this script, which only accounts for Bash, Linux,
tputbeing available, etc, and while doing that and building the prompt, I get a 15x (yes 1500%) speed improvement, which I benchmarked like this:time { for i in {1..1000}; do kube_ps1 > /dev/null; done }.However, this doesn't work for this script since we do it "lazily". I'd appreciate any way to benchmark this. I'd also appreciate some validation on ZSH before I mark this PR ready to review.