Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure compatibility with Java 21. #759

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

FrankenApps
Copy link

See this flutter issue and this PR for context.

This ensures that no warnings are emitted when building this package with Android Studio Ladybug / Java 21.

I contemplated setting

compileOptions {
    sourceCompatibility = JavaVersion.VERSION_17
    targetCompatibility = JavaVersion.VERSION_17
}

instead, because a lot of other popular packages require Java 17 nevertheless (for example see here or here), but ultimately decided to stick with Java 11 for improved compatibility for now, just like the official packages.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant