Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Present distances in km/mi #624

Draft
wants to merge 140 commits into
base: master
Choose a base branch
from

Commits on Dec 30, 2016

  1. Lint: Update workaround for GradleCompatible warning

    Will require manual checks or rewrite code
    
    Adding GraphView twice is done to force two inclusions and 'upgrade' the version of
    Android support library that GraphView was compiled with twice
    (GraphView is not used in 2.2 (but 2.3 "Froyo" builds). A wrapper will maybe suppress for Froyo.)
    
    TODO: Find how this should be handled without suppressions. The real benefit of a separate PR is to raise awareness.
    
    Note: RunnerUp, MapBox, GraphView, Play Services all uses different versions of Support Lib. One solution may be to compile MapBox and GraphView separately and adapt to PlayServices version....
    
    latestCompile - Classpath for compiling the latest sources.
    +--- com.android.support:design:25.1.0
    |    +--- com.android.support:support-v4:25.1.0
    |    |    +--- com.android.support:support-compat:25.1.0
    |    |    |    \--- com.android.support:support-annotations:25.1.0
    |    |    +--- com.android.support:support-media-compat:25.1.0
    |    |    |    +--- com.android.support:support-annotations:25.1.0
    |    |    |    \--- com.android.support:support-compat:25.1.0 (*)
    |    |    +--- com.android.support:support-core-utils:25.1.0
    |    |    |    +--- com.android.support:support-annotations:25.1.0
    |    |    |    \--- com.android.support:support-compat:25.1.0 (*)
    |    |    +--- com.android.support:support-core-ui:25.1.0
    |    |    |    +--- com.android.support:support-annotations:25.1.0
    |    |    |    \--- com.android.support:support-compat:25.1.0 (*)
    |    |    \--- com.android.support:support-fragment:25.1.0
    |    |         +--- com.android.support:support-compat:25.1.0 (*)
    |    |         +--- com.android.support:support-media-compat:25.1.0 (*)
    |    |         +--- com.android.support:support-core-ui:25.1.0 (*)
    |    |         \--- com.android.support:support-core-utils:25.1.0 (*)
    |    +--- com.android.support:appcompat-v7:25.1.0
    |    |    +--- com.android.support:support-annotations:25.1.0
    |    |    +--- com.android.support:support-v4:25.1.0 (*)
    |    |    +--- com.android.support:support-vector-drawable:25.1.0
    |    |    |    +--- com.android.support:support-annotations:25.1.0
    |    |    |    \--- com.android.support:support-compat:25.1.0 (*)
    |    |    \--- com.android.support:animated-vector-drawable:25.1.0
    |    |         \--- com.android.support:support-vector-drawable:25.1.0 (*)
    |    +--- com.android.support:recyclerview-v7:25.1.0
    |    |    +--- com.android.support:support-annotations:25.1.0
    |    |    +--- com.android.support:support-compat:25.1.0 (*)
    |    |    \--- com.android.support:support-core-ui:25.1.0 (*)
    |    \--- com.android.support:transition:25.1.0
    |         +--- com.android.support:support-annotations:25.1.0
    |         \--- com.android.support:support-v4:25.1.0 (*)
    +--- com.google.android.gms:play-services-wearable:10.0.1
    |    +--- com.google.android.gms:play-services-base:10.0.1
    |    |    +--- com.google.android.gms:play-services-basement:10.0.1
    |    |    |    \--- com.android.support:support-v4:24.0.0 -> 25.1.0 (*)
    |    |    \--- com.google.android.gms:play-services-tasks:10.0.1
    |    |         \--- com.google.android.gms:play-services-basement:10.0.1 (*)
    |    \--- com.google.android.gms:play-services-basement:10.0.1 (*)
    +--- com.getpebble:pebblekit:4.0.1
    +--- com.mapbox.mapboxsdk:mapbox-android-sdk:4.2.0
    |    +--- com.android.support:support-annotations:23.4.0 -> 25.1.0
    |    +--- com.android.support:support-v4:23.4.0 -> 25.1.0 (*)
    |    +--- com.android.support:design:23.4.0 -> 25.1.0 (*)
    |    +--- com.squareup.okhttp3:okhttp:3.4.1
    |    |    \--- com.squareup.okio:okio:1.9.0
    |    +--- com.mapzen.android:lost:1.1.1
    |    |    +--- com.android.support:appcompat-v7:22.2.0 -> 25.1.0 (*)
    |    |    +--- com.android.support:support-v4:22.2.0 -> 25.1.0 (*)
    |    |    \--- com.google.guava:guava:18.0
    |    \--- com.mapbox.mapboxsdk:mapbox-java-services:1.3.1
    |         +--- com.squareup.retrofit2:retrofit:2.1.0
    |         |    \--- com.squareup.okhttp3:okhttp:3.3.0 -> 3.4.1 (*)
    |         +--- com.squareup.retrofit2:converter-gson:2.1.0
    |         |    +--- com.squareup.retrofit2:retrofit:2.1.0 (*)
    |         |    \--- com.google.code.gson:gson:2.7
    |         \--- com.squareup.okhttp3:logging-interceptor:3.3.1
    |              \--- com.squareup.okhttp3:okhttp:3.3.1 -> 3.4.1 (*)
    \--- com.jjoe64:graphview:4.2.1
         \--- com.android.support:support-v4:22.1.1 -> 25.1.0 (*)
    gerhardol committed Dec 30, 2016
    Configuration menu
    Copy the full SHA
    5364eff View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    be2c2f0 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    25b945a View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    53d9d75 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    5a11030 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    507e90d View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    704c46f View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    d41d063 View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    1b6d03c View commit details
    Browse the repository at this point in the history
  10. Configuration menu
    Copy the full SHA
    3954831 View commit details
    Browse the repository at this point in the history
  11. Configuration menu
    Copy the full SHA
    d708e31 View commit details
    Browse the repository at this point in the history
  12. Configuration menu
    Copy the full SHA
    48931d9 View commit details
    Browse the repository at this point in the history
  13. Configuration menu
    Copy the full SHA
    7737902 View commit details
    Browse the repository at this point in the history
  14. Configuration menu
    Copy the full SHA
    c76f777 View commit details
    Browse the repository at this point in the history
  15. Lint: Hardcoded strings

    gerhardol committed Dec 30, 2016
    Configuration menu
    Copy the full SHA
    1f176c0 View commit details
    Browse the repository at this point in the history
  16. Lint: static field leak

    gerhardol committed Dec 30, 2016
    Configuration menu
    Copy the full SHA
    1d6de6a View commit details
    Browse the repository at this point in the history
  17. Configuration menu
    Copy the full SHA
    7f43db7 View commit details
    Browse the repository at this point in the history
  18. Configuration menu
    Copy the full SHA
    07af7f8 View commit details
    Browse the repository at this point in the history
  19. Configuration menu
    Copy the full SHA
    d87f468 View commit details
    Browse the repository at this point in the history
  20. Configuration menu
    Copy the full SHA
    1d1a7a4 View commit details
    Browse the repository at this point in the history
  21. Configuration menu
    Copy the full SHA
    7498648 View commit details
    Browse the repository at this point in the history
  22. Configuration menu
    Copy the full SHA
    6f2d8bf View commit details
    Browse the repository at this point in the history
  23. Lint: field can be local

    gerhardol committed Dec 30, 2016
    Configuration menu
    Copy the full SHA
    0766720 View commit details
    Browse the repository at this point in the history
  24. Configuration menu
    Copy the full SHA
    95a07a2 View commit details
    Browse the repository at this point in the history
  25. Configuration menu
    Copy the full SHA
    5f30c46 View commit details
    Browse the repository at this point in the history
  26. Configuration menu
    Copy the full SHA
    e172ebd View commit details
    Browse the repository at this point in the history
  27. Configuration menu
    Copy the full SHA
    073bb9c View commit details
    Browse the repository at this point in the history
  28. Configuration menu
    Copy the full SHA
    c692127 View commit details
    Browse the repository at this point in the history
  29. Configuration menu
    Copy the full SHA
    4559cbf View commit details
    Browse the repository at this point in the history
  30. Lint: Access can be weaker

    gerhardol committed Dec 30, 2016
    Configuration menu
    Copy the full SHA
    17147ba View commit details
    Browse the repository at this point in the history
  31. Configuration menu
    Copy the full SHA
    3e4c6a5 View commit details
    Browse the repository at this point in the history
  32. Configuration menu
    Copy the full SHA
    0dd9330 View commit details
    Browse the repository at this point in the history
  33. Configuration menu
    Copy the full SHA
    3d0a54c View commit details
    Browse the repository at this point in the history
  34. Configuration menu
    Copy the full SHA
    0cd1e95 View commit details
    Browse the repository at this point in the history
  35. Configuration menu
    Copy the full SHA
    b290c95 View commit details
    Browse the repository at this point in the history
  36. Configuration menu
    Copy the full SHA
    8864eb2 View commit details
    Browse the repository at this point in the history
  37. Lint: Various minor fixes

    gerhardol committed Dec 30, 2016
    Configuration menu
    Copy the full SHA
    f1e1abe View commit details
    Browse the repository at this point in the history
  38. Configuration menu
    Copy the full SHA
    be5cb2e View commit details
    Browse the repository at this point in the history
  39. Configuration menu
    Copy the full SHA
    2c92f6c View commit details
    Browse the repository at this point in the history
  40. Configuration menu
    Copy the full SHA
    fc76283 View commit details
    Browse the repository at this point in the history
  41. Configuration menu
    Copy the full SHA
    ea42f11 View commit details
    Browse the repository at this point in the history
  42. Configuration menu
    Copy the full SHA
    015c984 View commit details
    Browse the repository at this point in the history
  43. Lint: Expression is unused

    gerhardol committed Dec 30, 2016
    Configuration menu
    Copy the full SHA
    bc04fc3 View commit details
    Browse the repository at this point in the history
  44. Lint: Empty if/else clauses

    gerhardol committed Dec 30, 2016
    Configuration menu
    Copy the full SHA
    7ddc471 View commit details
    Browse the repository at this point in the history
  45. Configuration menu
    Copy the full SHA
    6bb8695 View commit details
    Browse the repository at this point in the history
  46. Configuration menu
    Copy the full SHA
    96bddd8 View commit details
    Browse the repository at this point in the history
  47. Lint: Unused imports

    gerhardol committed Dec 30, 2016
    Configuration menu
    Copy the full SHA
    198598d View commit details
    Browse the repository at this point in the history
  48. Configuration menu
    Copy the full SHA
    9bd2e5d View commit details
    Browse the repository at this point in the history
  49. Configuration menu
    Copy the full SHA
    e8385a2 View commit details
    Browse the repository at this point in the history
  50. Configuration menu
    Copy the full SHA
    6dc38cb View commit details
    Browse the repository at this point in the history
  51. Configuration menu
    Copy the full SHA
    fe4e805 View commit details
    Browse the repository at this point in the history
  52. Lint: ObsoleteSdkInt

    gerhardol committed Dec 30, 2016
    Configuration menu
    Copy the full SHA
    3ec95f6 View commit details
    Browse the repository at this point in the history
  53. Configuration menu
    Copy the full SHA
    2ebefbf View commit details
    Browse the repository at this point in the history
  54. Configuration menu
    Copy the full SHA
    c307149 View commit details
    Browse the repository at this point in the history
  55. Configuration menu
    Copy the full SHA
    93bc85b View commit details
    Browse the repository at this point in the history
  56. Configuration menu
    Copy the full SHA
    af841ed View commit details
    Browse the repository at this point in the history
  57. Configuration menu
    Copy the full SHA
    e447a3f View commit details
    Browse the repository at this point in the history
  58. Configuration menu
    Copy the full SHA
    68ecc41 View commit details
    Browse the repository at this point in the history
  59. Configuration menu
    Copy the full SHA
    6738e00 View commit details
    Browse the repository at this point in the history
  60. Lint: Unused import

    gerhardol committed Dec 30, 2016
    Configuration menu
    Copy the full SHA
    908b2aa View commit details
    Browse the repository at this point in the history
  61. Configuration menu
    Copy the full SHA
    79536fa View commit details
    Browse the repository at this point in the history
  62. Configuration menu
    Copy the full SHA
    271a5b5 View commit details
    Browse the repository at this point in the history
  63. Configuration menu
    Copy the full SHA
    0b22315 View commit details
    Browse the repository at this point in the history
  64. Configuration menu
    Copy the full SHA
    76914a9 View commit details
    Browse the repository at this point in the history
  65. Lint: Update workaround for GradleCompatible warning

    Will require manual checks or rewrite code
    
    //Adding GraphView twice is done to force two inclusions and 'upgrade' the version of
        //Android support library that GraphView was compiled with twice
        //GraphView is not used in Froyo though. A better fix if Froyo support is required,
        //would be to use a wrapper as for MapBox
    
    //Lint check cannot handle that there are different versions in different apk?
            //check manually with ./gradlew app:dependencies
    gerhardol committed Dec 30, 2016
    Configuration menu
    Copy the full SHA
    22cf000 View commit details
    Browse the repository at this point in the history
  66. Lint: TextView Internationalization, Number formatting does not take …

    …into account locale settings.
    
    TODO added in FeedActivity for strings to add and update
    gerhardol committed Dec 30, 2016
    Configuration menu
    Copy the full SHA
    4c0a894 View commit details
    Browse the repository at this point in the history
  67. Lint: Image without contentDescription

    Suppressed all warnings, related strings close by
    gerhardol committed Dec 30, 2016
    Configuration menu
    Copy the full SHA
    cfe8129 View commit details
    Browse the repository at this point in the history
  68. Configuration menu
    Copy the full SHA
    7caef49 View commit details
    Browse the repository at this point in the history
  69. Configuration menu
    Copy the full SHA
    e100e09 View commit details
    Browse the repository at this point in the history
  70. Lint: Useless parent layout

    gerhardol committed Dec 30, 2016
    Configuration menu
    Copy the full SHA
    939b4d3 View commit details
    Browse the repository at this point in the history
  71. Lint: Unused import

    gerhardol committed Dec 30, 2016
    Configuration menu
    Copy the full SHA
    a8e6f74 View commit details
    Browse the repository at this point in the history
  72. Lint: Constant Conditions

    gerhardol committed Dec 30, 2016
    Configuration menu
    Copy the full SHA
    47badd4 View commit details
    Browse the repository at this point in the history
  73. Configuration menu
    Copy the full SHA
    87916bb View commit details
    Browse the repository at this point in the history
  74. Configuration menu
    Copy the full SHA
    3bc36d0 View commit details
    Browse the repository at this point in the history
  75. Configuration menu
    Copy the full SHA
    2ce6cfd View commit details
    Browse the repository at this point in the history
  76. Configuration menu
    Copy the full SHA
    0cfaf2a View commit details
    Browse the repository at this point in the history
  77. Configuration menu
    Copy the full SHA
    4ec15d8 View commit details
    Browse the repository at this point in the history
  78. Configuration menu
    Copy the full SHA
    60dedd9 View commit details
    Browse the repository at this point in the history
  79. Configuration menu
    Copy the full SHA
    105d1a1 View commit details
    Browse the repository at this point in the history
  80. Lint: Suppress ButtonStyle warnings

    Change can be done on >= SDK 11 only
    Should be possible with separate xml (faild when attempting though), dont bother as this should be rewritten
    gerhardol committed Dec 30, 2016
    Configuration menu
    Copy the full SHA
    dc06247 View commit details
    Browse the repository at this point in the history
  81. Configuration menu
    Copy the full SHA
    2230efa View commit details
    Browse the repository at this point in the history
  82. Configuration menu
    Copy the full SHA
    b7742f2 View commit details
    Browse the repository at this point in the history
  83. Configuration menu
    Copy the full SHA
    79a4d12 View commit details
    Browse the repository at this point in the history
  84. Lint: FrameLayout can be replaced with <merge> tag

    If a <FrameLayout> is the root of a layout and does not provide background or padding etc, it can often be replaced with a <merge> tag which is slightly more efficient. Note that this depends on context, so make sure you understand how the <merge> tag works before proceeding.  http://android-developers.blogspot.com/2009/03/android-layout-tricks-3-optimize-by.html
    gerhardol committed Dec 30, 2016
    Configuration menu
    Copy the full SHA
    469aac7 View commit details
    Browse the repository at this point in the history
  85. Lint: SuppressLint("ClickableViewAccessibility")

    Code seem OK to me, not seeing that performClick() is beneficial.
    Suppressingseem to be the most common action.
    
    --
    ../../src/org/runnerup/widget/NumberPicker.java:231: org/runnerup/widget/NumberPicker$5#onTouch should call View#performClick when a click is detected
     228     private final OnTouchListener buttonLongTouchListener = new OnTouchListener() {
     229         @OverRide
     230         //@SuppressLint("ClickableViewAccessibility")
    
     231         public boolean onTouch(View v, MotionEvent event) {
    
     232             if (event.getAction() == MotionEvent.ACTION_UP &&
     233                     ((longInc && v == incButton) ||
     234                     (longDec && v == decButton))) {
    If a View that overrides onTouchEvent or uses an OnTouchListener does not also implement performClick and call it when clicks are detected, the View may not handle accessibility actions properly. Logic handling the click actions should ideally be placed in View#performClick as some accessibility services invoke performClick when a click action should occur.
    
    To suppress this error, use the issue id "ClickableViewAccessibility" as explained in the Suppressing Warnings and Errors section.
    gerhardol committed Dec 30, 2016
    Configuration menu
    Copy the full SHA
    7e1be51 View commit details
    Browse the repository at this point in the history
  86. Configuration menu
    Copy the full SHA
    d221b06 View commit details
    Browse the repository at this point in the history
  87. Lint: Declaration access can be weaker

    TitleSpinner changes, done on master
    gerhardol committed Dec 30, 2016
    Configuration menu
    Copy the full SHA
    d3283d6 View commit details
    Browse the repository at this point in the history
  88. Configuration menu
    Copy the full SHA
    a1d74a6 View commit details
    Browse the repository at this point in the history
  89. Remove @TargetApi() annotations

    This is used by Lint to set the minimal version when running Lint regardless of the version in Gradle. This is not needed as Lint runs separately for Latest and Froyo builds.
    The annotation is mostly confusing and too broad (not overriding where needed).
    In cases where the use level is raised (like Wear >= 4.3, some BLE code, MapBox etc) a version higher than minimum version can hide NewApi issues.
    In some cases the level was set too low (like Froyo in latest), potentially giving warnings that are irrelevant.
    
    The annotation was required here:
      \hrdevice\src\org\runnerup\hr\AndroidBLEHRProvider.java
      \app\src\org\runnerup\workout\feedback\RUTextToSpeech.java
    gerhardol committed Dec 30, 2016
    Configuration menu
    Copy the full SHA
    7197870 View commit details
    Browse the repository at this point in the history
  90. Revert @TargetApi() changes for a few files

      \hrdevice\src\org\runnerup\hr\RetryingHRProviderProxy.java
      \hrdevice\src\org\runnerup\hr\SamsungBLEHRProvider.java
    gerhardol committed Dec 30, 2016
    Configuration menu
    Copy the full SHA
    cfe380e View commit details
    Browse the repository at this point in the history

Commits on Apr 6, 2017

  1. Sync from Transifex

    Some manual changes, to keep strings where the source was changed
    Whitespace changes
    gerhardol committed Apr 6, 2017
    Configuration menu
    Copy the full SHA
    975e896 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    b138d30 View commit details
    Browse the repository at this point in the history
  3. Transifex sync after PR jonasoreland#525 - added attributes

    No changes, done to minimize noise at next update
    
    Unfortunately this is done in two PR: Need to have the PR for source file accepted before Transifex can be updated and the Transifex output changes can be added in a new PR
    gerhardol committed Apr 6, 2017
    Configuration menu
    Copy the full SHA
    f60ef6e View commit details
    Browse the repository at this point in the history
  4. Transifex Bosnian update

    gerhardol committed Apr 6, 2017
    Configuration menu
    Copy the full SHA
    30a0432 View commit details
    Browse the repository at this point in the history
  5. Transifex hu update

    Same as in PR jonasoreland#531, just bundled with other updates
    gerhardol committed Apr 6, 2017
    Configuration menu
    Copy the full SHA
    607cb53 View commit details
    Browse the repository at this point in the history
  6. Transifex fr update

    just one string
    gerhardol committed Apr 6, 2017
    Configuration menu
    Copy the full SHA
    36146c4 View commit details
    Browse the repository at this point in the history
  7. Transifex CS update

    gerhardol committed Apr 6, 2017
    Configuration menu
    Copy the full SHA
    c3f8686 View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    c6feab3 View commit details
    Browse the repository at this point in the history
  9. Lint findings

    (seen after merging to the lint-eliminations branch)
    gerhardol committed Apr 6, 2017
    Configuration menu
    Copy the full SHA
    7ea94bb View commit details
    Browse the repository at this point in the history
  10. Lint: GradleCompatible, force support-v4 version

    GradleCompatible: support-v4 is not used directly by app source but mapbox, graphview, play-services-wearable
    force same version as in the app
    
    Handle GradleDependency in Froyo
    
    RestrictedApi no longer occurs
    gerhardol committed Apr 6, 2017
    Configuration menu
    Copy the full SHA
    0fc7214 View commit details
    Browse the repository at this point in the history
  11. Configuration menu
    Copy the full SHA
    974d9ea View commit details
    Browse the repository at this point in the history
  12. Configuration menu
    Copy the full SHA
    afb4d9e View commit details
    Browse the repository at this point in the history
  13. Configuration menu
    Copy the full SHA
    1324257 View commit details
    Browse the repository at this point in the history

Commits on Apr 11, 2017

  1. Lint false positives: Link to reports

    Remove some workarounds that could be overlaying the eventual corrections
    gerhardol committed Apr 11, 2017
    Configuration menu
    Copy the full SHA
    8f24b3f View commit details
    Browse the repository at this point in the history

Commits on Apr 26, 2017

  1. Configuration menu
    Copy the full SHA
    03d157d View commit details
    Browse the repository at this point in the history
  2. Ignore LogNotTimber lint

    gerhardol committed Apr 26, 2017
    Configuration menu
    Copy the full SHA
    5e389f3 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    b094314 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    4135768 View commit details
    Browse the repository at this point in the history

Commits on Apr 28, 2017

  1. Configuration menu
    Copy the full SHA
    89faa92 View commit details
    Browse the repository at this point in the history

Commits on May 3, 2017

  1. Configuration menu
    Copy the full SHA
    c968170 View commit details
    Browse the repository at this point in the history

Commits on Jun 18, 2017

  1. Merge branch 'master' into test/lint-eliminations-merge2

    Some manual conflict resolutions, no functionality changes
    
    # Conflicts:
    #	app/latest/java/org/runnerup/tracker/component/TrackerWear.java
    #	app/src/org/runnerup/util/Formatter.java
    #	app/src/org/runnerup/view/DetailActivity.java
    #	app/src/org/runnerup/view/RunActivity.java
    #	app/src/org/runnerup/view/StepButton.java
    #	app/src/org/runnerup/workout/Workout.java
    #	build.gradle
    #	common/src/main/java/org/runnerup/common/util/Constants.java
    #	wear/src/main/java/org/runnerup/service/StateService.java
    #	wear/src/main/java/org/runnerup/view/MainActivity.java
    #	wear/src/main/java/org/runnerup/view/RunInfoFragment.java
    #	wear/src/main/res/layout/card3.xml
    #	wear/src/main/res/layout/newlap.xml
    #	wear/src/main/res/layout/pause_resume.xml
    gerhardol committed Jun 18, 2017
    Configuration menu
    Copy the full SHA
    f650b8a View commit details
    Browse the repository at this point in the history
  2. Some new lint from master

    Case change in printout: Hardcoded for "lap pace" is now (in English) "Lap pace"
    gerhardol committed Jun 18, 2017
    Configuration menu
    Copy the full SHA
    0da3176 View commit details
    Browse the repository at this point in the history

Commits on Jul 22, 2017

  1. Configuration menu
    Copy the full SHA
    f0bef09 View commit details
    Browse the repository at this point in the history

Commits on Jul 28, 2017

  1. AS2.3 Gradle plugin update

    gerhardol committed Jul 28, 2017
    Configuration menu
    Copy the full SHA
    eeb45bc View commit details
    Browse the repository at this point in the history
  2. Merge remote-tracking branch 'origin/master' into _pr/lint-eliminations

    # Conflicts:
    #	app/src/org/runnerup/export/StravaSynchronizer.java
    #	app/src/org/runnerup/view/CreateAdvancedWorkout.java
    gerhardol committed Jul 28, 2017
    Configuration menu
    Copy the full SHA
    501c8d3 View commit details
    Browse the repository at this point in the history

Commits on Jul 30, 2017

  1. Configuration menu
    Copy the full SHA
    e1c2bb8 View commit details
    Browse the repository at this point in the history

Commits on Jul 31, 2017

  1. Configuration menu
    Copy the full SHA
    1bf1c2b View commit details
    Browse the repository at this point in the history
  2. Lint: suppress ClickableViewAccessibility

    Suppress in code not working with gradle 3.0.0?
    gerhardol committed Jul 31, 2017
    Configuration menu
    Copy the full SHA
    1856ee9 View commit details
    Browse the repository at this point in the history
  3. Lint: Eliminate PrivateResource for GoogleFitData

    Probably bad check, it refers to MapBox
    gerhardol committed Jul 31, 2017
    Configuration menu
    Copy the full SHA
    803e4a2 View commit details
    Browse the repository at this point in the history
  4. Lint: Suppress StaticFieldLeak

    All of the usage I see uses local variables, so a static inner class is not possible. The usage seem to be within the "calling activity" so leak should be minor
    gerhardol committed Jul 31, 2017
    Configuration menu
    Copy the full SHA
    f3f3e12 View commit details
    Browse the repository at this point in the history
  5. Lint: Add baseline files, suppressing non interesting issues

    Currently those with Lint bugs
    gerhardol committed Jul 31, 2017
    Configuration menu
    Copy the full SHA
    48592be View commit details
    Browse the repository at this point in the history
  6. Prepare for Android Studio 3: Add Google repo, set flavorDimension

    Also update Android gradle plugin
    The preparation has no functional change for AS2.3, but it easier to switch between the versions
    gerhardol committed Jul 31, 2017
    Configuration menu
    Copy the full SHA
    ae742c8 View commit details
    Browse the repository at this point in the history
  7. Add Google repository for app/wear

    Google no longer distributes libs with jcenter(), uses its own repo
    gerhardol committed Jul 31, 2017
    Configuration menu
    Copy the full SHA
    8c52664 View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    abe3d92 View commit details
    Browse the repository at this point in the history

Commits on Aug 9, 2017

  1. Configuration menu
    Copy the full SHA
    9f25f94 View commit details
    Browse the repository at this point in the history
  2. Lint: Updated comments for GradleCompatible

    No longer required for AS3
    gerhardol committed Aug 9, 2017
    Configuration menu
    Copy the full SHA
    5c3b80d View commit details
    Browse the repository at this point in the history
  3. Ignore gen/

    gerhardol committed Aug 9, 2017
    Configuration menu
    Copy the full SHA
    1284c80 View commit details
    Browse the repository at this point in the history

Commits on Aug 11, 2017

  1. Merge remote-tracking branch 'origin/master' into pr/524-lint-elimina…

    …tions
    
    # Conflicts:
    #	.gitignore
    #	.travis.yml
    #	app/AndroidManifest.xml
    #	app/latest/java/org/runnerup/feedwidget/FeedWidgetService.java
    #	app/lint-baseline.xml
    #	app/src/org/runnerup/db/DBHelper.java
    #	app/src/org/runnerup/export/DefaultSynchronizer.java
    #	app/src/org/runnerup/export/DigifitSynchronizer.java
    #	app/src/org/runnerup/export/EndomondoSynchronizer.java
    #	app/src/org/runnerup/export/FileSynchronizer.java
    #	app/src/org/runnerup/export/FunBeatSynchronizer.java
    #	app/src/org/runnerup/export/GarminSynchronizer.java
    #	app/src/org/runnerup/export/GoogleFitSynchronizer.java
    #	app/src/org/runnerup/export/RunKeeperSynchronizer.java
    #	app/src/org/runnerup/export/RuntasticSynchronizer.java
    #	app/src/org/runnerup/view/AccountListActivity.java
    #	build.gradle
    #	common/src/main/java/org/runnerup/common/util/Constants.java
    #	hrdevice/src/org/runnerup/hr/HRManager.java
    #	wear/lint-baseline.xml
    gerhardol committed Aug 11, 2017
    Configuration menu
    Copy the full SHA
    58628a6 View commit details
    Browse the repository at this point in the history
  2. Various inspect changes

    unused import
    unused parameters and methods
    variable can be final
    access can be private
    array type init
    constantconditions
    
    A few suppressions
    gerhardol committed Aug 11, 2017
    Configuration menu
    Copy the full SHA
    de79cde View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    243c48d View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    d7d245c View commit details
    Browse the repository at this point in the history
  5. Target Android O

    gerhardol committed Aug 11, 2017
    Configuration menu
    Copy the full SHA
    3f51ea3 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    2e95239 View commit details
    Browse the repository at this point in the history
  7. Revert "ANT+ lib should be provided, not compile"

    This reverts commit d7d245c.
    gerhardol committed Aug 11, 2017
    Configuration menu
    Copy the full SHA
    5b8ec1d View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    7c83f1d View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    73f56ab View commit details
    Browse the repository at this point in the history

Commits on Aug 13, 2017

  1. Revert "Target Android O"

    To be added when source is released
    This reverts commit 3f51ea3.
    gerhardol committed Aug 13, 2017
    Configuration menu
    Copy the full SHA
    fc00155 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    a31b479 View commit details
    Browse the repository at this point in the history

Commits on Aug 20, 2017

  1. Present distances in km/mi

    Previously 'm' was used in most of the interface
    Distances shorter than 1000m are presented in m (also statue, as there is no possibility to set feet/yard).
    The Distance picker were previously in whole km/mi with separate meter, now only km/mi
    Some hardcoded use of 'm' removed
    gerhardol committed Aug 20, 2017
    Configuration menu
    Copy the full SHA
    76ed2bd View commit details
    Browse the repository at this point in the history
  2. Froyo NewApi lint errors

    gerhardol committed Aug 20, 2017
    Configuration menu
    Copy the full SHA
    49181d1 View commit details
    Browse the repository at this point in the history