Upgraded prometheus to newest version #122
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@johrstrom would be nice if you could review my PR. I ugraded the prometheus client to newest version 0.16.0 and fixed the tests accordingly. |
|
@johrstrom any update? :-) |
|
Sorry for the delay, I'll carve out some time tonight to sort this out. |
|
Hey, I'm so sorry for the delay. I'll get this pushed out in a tag shortly. I just had to rebase for you. The tests changes through me off a bit so I had to look up the changes upstream. Thanks for the contribution and again, sorry for the delay. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upgraded Prometheus to latest version.
Fixed unit tests as there is a new default metric called "_created". See: https://github.com/prometheus/client_java/releases/tag/parent-0.10.0