Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open with external application #1372

Merged

Conversation

axlEscalada
Copy link
Contributor

  • add functionality to open files with an external application

related to: #1343

@johnfactotum
Copy link
Owner

Thanks! Can you make it follow the project's coding style, 4 spaces and no semicolons?

@axlEscalada
Copy link
Contributor Author

axlEscalada commented Aug 8, 2024

Thanks! Can you make it follow the project's coding style, 4 spaces and no semicolons?

It's done.
Btw I love foliate <3

@johnfactotum
Copy link
Owner

Thanks. The indentation is still incorrect, though. You can see this if you run npx eslint.

@axlEscalada
Copy link
Contributor Author

Thanks. The indentation is still incorrect, though. You can see this if you run npx eslint.

thanks for the hint, I ran npx eslint --fix to fix the format

@johnfactotum johnfactotum merged commit 278677f into johnfactotum:gtk4 Aug 28, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants