small optimizations, deactivate SAN because of gcc bug

.github/workflows/ci.yml

@@ -130,18 +130,6 @@ jobs:
 
 
     steps:
-      - name: Set up Ubuntu version codename
-        id: set-codename
-        run: |
-          if [ "${{ matrix.os }}" == "ubuntu-20.04" ]; then
-            echo "::set-output name=ubuntu-codename::focal"
-          elif [ "${{ matrix.os }}" == "ubuntu-22.04" ]; then
-            echo "::set-output name=ubuntu-codename::jammy"
-          else
-            echo "::error ::Unsupported Ubuntu version"
-            exit 1
-          fi
-
       - name: Check for llvm version mismatches
         if: ${{ contains(matrix.compiler, 'llvm') && !contains(matrix.compiler, env.CLANG_TIDY_VERSION) }}
         uses: actions/github-script@v3
@@ -204,7 +192,7 @@ jobs:
       - name: Install cmake
         run: |
               wget -O - https://apt.kitware.com/keys/kitware-archive-latest.asc 2>/dev/null | gpg --dearmor - | sudo tee /etc/apt/trusted.gpg.d/kitware.gpg >/dev/null && \
-              sudo apt-add-repository -y "deb https://apt.kitware.com/ubuntu/ ${{ steps.set-codename.outputs.ubuntu-codename }} main" && \
+              sudo apt-add-repository -y "deb https://apt.kitware.com/ubuntu/ $(lsb_release -cs) main" && \
               sudo apt-get update -qq && export DEBIAN_FRONTEND=noninteractive && \
               sudo apt-get install -y --no-install-recommends cmake cmake-curses-gui
 

CMakeLists.txt

@@ -16,7 +16,7 @@ set(CMAKE_CXX_EXTENSIONS OFF)
 # Set the project name and language
 project(
   anywho
-  VERSION 0.0.3
+  VERSION 0.0.7
   DESCRIPTION ""
   HOMEPAGE_URL "https://github.com/johannes-graeter/anywho"
   LANGUAGES CXX C)

ProjectOptions.cmake

@@ -11,11 +11,11 @@ macro(anywho_supports_sanitizers)
     set(SUPPORTS_UBSAN OFF)
   endif()
 
-  if((CMAKE_CXX_COMPILER_ID MATCHES ".*Clang.*" OR CMAKE_CXX_COMPILER_ID MATCHES ".*GNU.*") AND WIN32)
+  # if((CMAKE_CXX_COMPILER_ID MATCHES ".*Clang.*" OR CMAKE_CXX_COMPILER_ID MATCHES ".*GNU.*") AND WIN32)
     set(SUPPORTS_ASAN OFF)
-  else()
-    set(SUPPORTS_ASAN ON)
-  endif()
+  # else()
+    # set(SUPPORTS_ASAN ON)
+  # endif()
 endmacro()
 
 macro(anywho_setup_options)

include/error_factories.hpp

@@ -22,7 +22,7 @@ template<typename T, concepts::Error E>
 inline std::expected<T, E> make_error(bool has_no_error, T truth_value, E &&error)
 {
   if (has_no_error) {
-    return truth_value;
+    return std::expected<T, E>{ truth_value };
   } else {
     return std::unexpected(error);
   }
@@ -40,7 +40,7 @@ inline std::expected<T, E> make_error(bool has_no_error, T truth_value, E &&erro
 template<typename T, concepts::Error E>
 inline std::expected<T, E> make_error(std::function<std::tuple<bool, T>(void)> callable, E &&error)
 {
-  const auto &[has_no_error, truth_value] = callable();
+  const auto [has_no_error, truth_value] = callable();
 
   return make_error(has_no_error, truth_value, std::move(error));
 }
@@ -56,7 +56,7 @@ inline std::expected<T, E> make_error(std::function<std::tuple<bool, T>(void)> c
 template<typename T> inline std::expected<T, ErrorFromCode> make_error(std::error_code error_code, T truth_value)
 {
   if (!error_code) {
-    return truth_value;
+    return std::expected<T, ErrorFromCode>{ truth_value };
   } else {
     return std::unexpected(ErrorFromCode(error_code));
   }
@@ -73,7 +73,7 @@ template<typename T> inline std::expected<T, ErrorFromCode> make_error(std::erro
 template<typename T>
 inline std::expected<T, ErrorFromCode> make_error(std::function<std::tuple<std::error_code, T>(void)> callable)
 {
-  const auto &[error_code, truth_value] = callable();
+  const auto [error_code, truth_value] = callable();
 
   return make_error(error_code, truth_value);
 }