Small fixes! #2
Small fixes! #2
Conversation
- fixed Tube hitboxes - fixed nextTubeHeight calculation and proper jump - renamed "Colums passed: " to the real data it shows "Fitness: "
| @@ -101,7 +101,7 @@ public void update() { | |||
| if (dead) return; | |||
|
|
|||
| double birdYPossition = (double)yPos/Resources.HEIGHT; | |||
| double nextTubeHeigth = ((Resources.nextTube.getY() + Resources.TUBE_HEIGHT + Resources.TUBE_GAP_DISTANCE/2)-560+Resources.TUBE_HEIGHT)/(-260+560); // 80-380 | |||
| double nextTubeHeigth = ((Resources.nextTube.getY() + Resources.TUBE_HEIGHT + Resources.TUBE_GAP_DISTANCE/2)-560+Resources.TUBE_HEIGHT)/(700); // 80-380 | |||
There was a problem hiding this comment.
This will not evaluate to the same value (original's divide is 300, where as the replacement is 700), also the parentheses on the right can be removed.
There was a problem hiding this comment.
I run the code several times for hours. The birds were evolving but never reached the point where they could pass more than 4 tubes. I noticed that the they could pass tubes when they were nearly at equal height but when there was a big difference then they accelerated to much or dropped too low. They learnet which way to fly but they overdone it. This change fixed this issue for me.
There was a problem hiding this comment.
Ahh, well in thatcase the comment at the end of the line should probably be fixed ;)
| @@ -124,11 +124,11 @@ public void update() { | |||
| if (Resources.IN_TUBE) { | |||
| int leftBird = Resources.BIRD_X_POSITION; | |||
| int rightBird = Resources.BIRD_X_POSITION + Resources.BIRD_WIDTH; | |||
| int leftTube = (int) Resources.CURRENT_TUBE.getX(); | |||
| int rightTube = (int) Resources.CURRENT_TUBE.getX() + Resources.TUBE_WIDTH; | |||
| int leftTube = (int) Resources.CURRENT_TUBE.getX()+50; | |||
There was a problem hiding this comment.
I noticed that when I run the game the birds died before reaching the tubes. So I tried to fix the collision detecetion by changing the values.
There was a problem hiding this comment.
Maybe give the constants useful names? from reading the code I can't automatically know what that is doing
There was a problem hiding this comment.
Have you run the code on your machine? This bug is interesting and its maybe just on my machine. Birds really shouldnt collide with thin air. :)
Edit: Later I might work more on it and change names and stuff but otherwise I'm new to programming and this was my first glance at java.
There was a problem hiding this comment.
I have difficulties compiling it, because it's confusing to me (I don't use java) I don't really care that the constants exist, but they should be given names (like pi instead of 3.14159265 - even though that isn't used here) because that helps people who are new to the project understand the code.
(I do agree however, that birds shouldn't collide with thin air)
There was a problem hiding this comment.
nvm, got it to run, the birds do collide with air
There was a problem hiding this comment.
You ran the one with my changes and they still die before the tubes?
There was a problem hiding this comment.
Ah, I meant the original, this fixes the problem 👍 got a gen 2 bird to go forever with your version.
Small fixes I found while testing your version. Now runs smooth and learns correctly