Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unbreak on FreeBSD 12+ #133

Closed
wants to merge 1 commit into from
Closed

Unbreak on FreeBSD 12+ #133

wants to merge 1 commit into from

Commits on Apr 10, 2019

  1. Unbreak on FreeBSD 12+ 

    FreeBSD 12 switched to 64 bits inodes, and struct stat was updated
accordingly:
freebsd/freebsd-src@e75ba1d

On recent FreeBSD, due to struct stat size change, jnr-posix acts
inconsistently.

Fix the issue by forcing usage of the legacy API which is available
through versioned symbols.

Running the test suite on FreeBSD before this change produces:

> Tests run: 93, Failures: 10, Errors: 3, Skipped: 1
>
> Failed tests:
>   FileStatTest.filestat:63 expected:<1567> but was:<149054000>
>   FileStatTest.filestatDirectory:196 null
>   FileTest.futimeTest:185 mtime failed
>   FileTest.futimens:144->assertStatNanoSecond:661 Access timestamp should be updated expected:<4299262296485> but was:<4299262296484>
>   FileTest.lutimesTest:162 atime seconds failed expected:<800> but was:<4299262296484>
>   FileTest.utimensatAbsolutePath:115->utimensat:656->assertStatNanoSecond:661 Access timestamp should be updated expected:<4299262296486> but was:<4299262296484>
>   FileTest.utimensatRelativePath:124->utimensat:656->assertStatNanoSecond:661 Access timestamp should be updated expected:<4299262296486> but was:<4299262296484>
>   FileTest.utimesDefaultValuesTest:73 mtime failed
>   FileTest.utimesPointerTest:95 atime seconds failed expected:<800> but was:<4299262296484>
>   FileTest.utimesTest:42 atime seconds failed expected:<800> but was:<4299262296484>

With this change, the results are:

> Tests run: 93, Failures: 0, Errors: 3, Skipped: 1

Tests in error rely on unimplemented methods for FreeBSD and are
expected:

> Tests in error:
>   EnvTest.testEnv:70 » UnsupportedOperation unimplemented method: environ
>   IOTest.testSendRecvMsg_NoControl:115 » UnsupportedOperation unimplemented method: allocateMsgHdr
>   IOTest.testSendRecvMsg_WithControl:163 » UnsupportedOperation unimplemented method: allocateMsgHdr
    @smortex
    smortex committed Apr 10, 2019
    Configuration menu
    Copy the full SHA
    92c02b2 View commit details
    Browse the repository at this point in the history