Elligator2 Subgroup Distinguisher #46
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #46 +/- ##
==========================================
+ Coverage 77.75% 78.48% +0.73%
==========================================
Files 35 35
Lines 5610 5681 +71
Branches 5610 5681 +71
==========================================
+ Hits 4362 4459 +97
+ Misses 857 831 -26
Partials 391 391 ☔ View full report in Codecov by Sentry. |
jmwample
force-pushed
the
hs-distinguisher
branch
from
263e31d
to
42b4b84
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding tests for elligator2 subgroup distinguisher reveals that the rust implementation seems to handle this improperly. This PR is a space to investigate this and ensure a proper implementation.