Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix handling of supertraits, fix #21 #22

Merged
merged 1 commit into from
Aug 15, 2024

Conversation

MingweiSamuel
Copy link
Contributor

No description provided.

@jmg-duarte
Copy link
Owner

Now I'm wondering... does the sealed trait need to have generics at all? Could it just always be trait Sealed {}?
— from #21

I don't think the sealed trait needs the bounds or even the generics AFAIK. I'll need to go back and understand why we've added the bounds.

Apologies as it will take a bit more to merge (or not)

@jmg-duarte jmg-duarte merged commit b9fe92b into jmg-duarte:main Aug 15, 2024
3 checks passed
jmg-duarte added a commit that referenced this pull request Aug 15, 2024
* adds support for supertrait's associated types — #22
* remove dependency on heck
@jmg-duarte
Copy link
Owner

I've published 0.6.0-rc1 — https://crates.io/crates/sealed/0.6.0-rc1

Take it for a spin and let me know if you find anything (or not)!

@MingweiSamuel MingweiSamuel deleted the supertrait branch September 24, 2024 04:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants