Enable goverter:enum on goverter:variables mode #155
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for this nice project. goverter saves a lot of my time.
goverter v1.5.0 has introduced the
goverter:variables
conversion mode. In this mode,goverter:enum
turns off unexpectedly.goverter:enum
should be enabled by default by the documentation.I investigated the issue and guessed the reason for this problem. There are two default configurations
DefaultConfigInterface
andDefaultConfigVariables
which turn ongoverter:enum
.DefaultConfigInterface
is used for thegoverter:converter
mode as its name indicates, butDefaultConfigVariables
is not used for thegoverter:variables
mode.This patch enables
DefaultConfigVariables
for thegoverter:variables
mode to fix the problem. You can prove it byvar_enum.yml
test scenario I added. This scenario fails without this patch.Thank you.