SQLITE Contention: Add retries and enable WAL mode #355
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Using SQLITE's busy timeout didn't fix the issue with busy errors preventing sessions from being updated and learning from occuring. * Add logic at the application layer to retry the updates. * Use an atomic counter to track the number of concurrent updates to try to confirm we don't have multiple concurrent writes.
✅ Deploy Preview for foyle canceled.
|
…s will help us better understand the lag in log processing.
…database. Add a Gauge to measure lag between current time and last processed log time.
jlewi
changed the title
![standard-input[bot]](https://avatars.githubusercontent.com/in/1011034?s=60&v=4){kind=small}
| @@ -86,11 +86,9 @@ type ConvertDocRequest struct { | |||
|
|
|||
| func (x *ConvertDocRequest) Reset() { | |||
There was a problem hiding this comment.
Suggested change
| func (x *ConvertDocRequest) Reset() { | |
| // Reset resets the ConvertDocRequest to its zero value. | |
| func (x *ConvertDocRequest) Reset() { |
add comment to Reset method
| @@ -565,11 +551,9 @@ type GetBlockLogRequest struct { | |||
|
|
|||
| func (x *GetBlockLogRequest) Reset() { | |||
There was a problem hiding this comment.
Suggested change
| func (x *GetBlockLogRequest) Reset() { | |
| // Reset resets the GetBlockLogRequest to its zero value. | |
| func (x *GetBlockLogRequest) Reset() { |
add comment to Reset method
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
we don't have multiple concurrent writes.