Added check for nested scrollbars #57
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chore(Standardization): creating default export file
Update Dependences to RC1
Dynamic content support using mutation observer.
fix: swap directions of mobile scrolling
fix: enable clicks on mobile devices
fix 100% height
…d-local is set to true
removed unused local declarations - fixes tslint errors when no-unused-local is set to true
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a check to the scrolling so that when you're scrolling with the mouse-wheel if you've reached the top or bottom (ie: the scroll doesn't make an actual change) then allow the even to bubble up, and if it hasn't, prevent all propagation. This ensures that when you have nested scroll bars, if you wheel down inside the inner scroll it won't move the outer scroll unless the inner one has hit the bottom.