Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: removed unnecessary offset in daysBetween() #539

Merged
merged 3 commits into from
Nov 10, 2023
Merged

fix: removed unnecessary offset in daysBetween() #539

merged 3 commits into from
Nov 10, 2023

Conversation

dereekb
Copy link
Contributor

@dereekb dereekb commented Jul 15, 2022

Fixes #537.

TZ=Pacific/Kiritimati yarn test will now pass.

Thanks for contributing to rrule!

To submit a pull request, please verify that you have done the following:

  • Merged in or rebased on the latest master commit
  • Linked to an existing bug or issue describing the bug or feature you're
    addressing
  • Written one or more tests showing that your change works as advertised

hmassad
hmassad approved these changes Mar 25, 2023
View reviewed changes
Copy link

@hmassad hmassad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it works, please merge this

@nsb
Copy link

nsb commented Oct 1, 2023

This really needs to be merged. 🙏

@davidgoli davidgoli merged commit 26c799f into jkbrzt:master Nov 10, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hmassad hmassad hmassad approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Tests fail when run from TZ=Pacific/Kiritimati
4 participants
@dereekb @nsb @hmassad @davidgoli