ci: add support for linux-arm64 #889
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
saghul
reviewed
Jul 16, 2023
Update electron-builder to be able to disable rebuilds, everything is prebuild anyway. As part of electron-builder upgrade, fix sign and notarize on pull requests for mac and continue to notarize outside of builder, because notarize within electron-builder required teamId to be set in build config, but we want to keep that in env for now See https://github.com/electron-userland/electron-builder/blob/master/packages/app-builder-lib/src/macPackager.ts#L525
|
Its now ready for review, I have already tested it successfully on a Raspberry Pi with arm64 raspbian (bullseye). Due to the required electron-builder update I also did retests on Windows, Ubuntu and macOS, just to be sure that functionality and autoupdate still work as expected. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update electron-builder to be able to disable rebuilds, everything is prebuild anyway.
As part of electron-builder upgrade, fix sign and notarize on pull
requests for mac and continue to notarize outside of builder, because notarize within electron-builder
required teamId to be set in build config, but we want to keep that in env for now
See https://github.com/electron-userland/electron-builder/blob/master/packages/app-builder-lib/src/macPackager.ts#L525