Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add signaling for VLA RTP header extension. #1203

Merged
merged 1 commit into from
Dec 12, 2024
Merged

feat: Add signaling for VLA RTP header extension. #1203

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions jicofo-common/src/main/kotlin/org/jitsi/jicofo/codec/CodecConfig.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -139,6 +139,9 @@ class Config {
val av1DependencyDescriptor: RtpExtensionConfig =
RtpExtensionConfig("jicofo.codec.rtp-extensions.av1-dependency-descriptor")

val videoLayersAllocation: RtpExtensionConfig =
RtpExtensionConfig("jicofo.codec.rtp-extensions.video-layers-allocation")

@JvmField
val tof: RtpExtensionConfig =
RtpExtensionConfigWithLegacy("$LEGACY_BASE.ENABLE_TOF", "jicofo.codec.rtp-extensions.tof")
Expand Down
9 changes: 9 additions & 0 deletions jicofo-common/src/main/kotlin/org/jitsi/jicofo/codec/CodecUtil.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -206,6 +206,15 @@ class CodecUtil {
fun createVideoRtpHdrExtExtensions(
options: OfferOptions = OfferOptions()
): Collection<RTPHdrExtPacketExtension> = buildList {
if (config.videoLayersAllocation.enabled) {
// a=extmap:12 http://www.webrtc.org/experiments/rtp-hdrext/video-layers-allocation00
add(
RTPHdrExtPacketExtension().apply {
id = config.videoLayersAllocation.id.toString()
uri = URI.create("http://www.webrtc.org/experiments/rtp-hdrext/video-layers-allocation00")
}
)
}
if (config.av1DependencyDescriptor.enabled()) {
// https://aomediacodec.github.io/av1-rtp-spec/#dependency-descriptor-rtp-header-extension
val dependencyDescriptorExt = RTPHdrExtPacketExtension()
Expand Down
4 changes: 4 additions & 0 deletions jicofo-selector/src/main/resources/reference.conf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -142,6 +142,10 @@ jicofo {
enabled = true
id = 11
}
video-layers-allocation {
enabled = false
id = 12
}
tof {
// TOF is currently disabled, because we don't support it in the bridge
// (and currently clients seem to not use it when abs-send-time is
Expand Down
Loading