Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(visitors): Make sure we disconnect vnodes before leaving rooms. #1170

Merged
merged 2 commits into from
Sep 20, 2024
Merged

fix(visitors): Make sure we disconnect vnodes before leaving rooms. #1170

merged 2 commits into from
Sep 20, 2024

Commits on Sep 18, 2024

  1. fix(visitors): Make sure we disconnect vnodes before leaving rooms. 

    Use case is a single main participant and a visitor node. If jicofo leaves visitor room before disconnecting, the client will reload seeing jicofo leaving. If we disconnect first, we destroy the room with an appropriate message shown to visitors.
    @damencho
    damencho committed Sep 18, 2024
    Configuration menu
    Copy the full SHA
    f65f3d6 View commit details
    Browse the repository at this point in the history

Commits on Sep 19, 2024

  1. squash: synchronize, refactor.

    @bgrozev
    bgrozev committed Sep 19, 2024
    Configuration menu
    Copy the full SHA
    b6ee464 View commit details
    Browse the repository at this point in the history