Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Monitor visitors' codec lists, and aggregate them into a conference property. #1137

Merged
merged 11 commits into from
Feb 27, 2024
Merged

Monitor visitors' codec lists, and aggregate them into a conference property. #1137

Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
33f724a
Monitor visitors' codec lists, and aggregate them into a conference p…
JonathanLennox Feb 23, 2024
e257dfb
Fix typo in test.
JonathanLennox Feb 26, 2024
e926015
Add unit test for PreferenceAggregator.X
JonathanLennox Feb 26, 2024
e71e23e
Guard against repeated values in preferences.
JonathanLennox Feb 27, 2024
22d8240
Support older clients which send jitsi_participant_codecType.
JonathanLennox Feb 27, 2024
208e1e7
Protect against codec list being changed in updated presence messages.
JonathanLennox Feb 27, 2024
c764b53
Don't re-warn about codec lists not containing vp8 on presence updates.
JonathanLennox Feb 27, 2024
3629ab4
Make sure to force codecType to lowercase.
JonathanLennox Feb 27, 2024
b7b53f3
Update jitsi-xmpp-extensions.
JonathanLennox Feb 27, 2024
d85aa96
Checkstyle fix.
JonathanLennox Feb 27, 2024
c48563d
Add debug state for visitor codec aggregation.
JonathanLennox Feb 27, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion jicofo-common/src/main/kotlin/org/jitsi/jicofo/xmpp/muc/ChatRoomMemberImpl.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -223,7 +223,16 @@ class ChatRoomMemberImpl(
} else {
videoCodecs = it.codecs
}
}
} ?: // Older clients sent a single codec in codecType rather than all supported ones in codecList
presence.getExtensionElement("jitsi_participant_codecType", "jabber:client")?.let {
if (it is StandardExtensionElement) {
videoCodecs = if (it.text == "vp8") {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In JitsiParticipantCodecList.kt you use lowercase(). Is it also required here?

listOf(it.text)
} else {
listOf(it.text, "vp8")
}
}
}
}

/**
Expand Down