Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tcptype to Candidate toString method #132

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jalaziz
Copy link

@jalaziz jalaziz commented Oct 19, 2017

No description provided.

@jitsi-jenkins
Copy link

Hi, thanks for your contribution!
If you haven't already done so, could you please make sure you sign our CLA (https://jitsi.org/icla for individuals and https://jitsi.org/ccla for corporations)? We would unfortunately be unable to merge your patch unless we have that piece :(.

@jalaziz jalaziz force-pushed the candidate-tcp-type branch from a5c8126 to b63b1d6 Compare October 19, 2017 06:54
@jalaziz
Copy link
Author

jalaziz commented Oct 19, 2017

I also noticed Candidate doesn't take tcpType into account for equals. I didn't want to assume it was safe to add tcpType to equals(), since it could result in breaking code. However, I believe it's the right thing to do.

Also, remove redundancy in generatig candidate SDP attribute strings.
@jalaziz jalaziz force-pushed the candidate-tcp-type branch from b63b1d6 to 0a12d4d Compare October 19, 2017 07:35
@jalaziz
Copy link
Author

jalaziz commented Oct 23, 2017

As it turns out, Chrome does not accept the tcptype attribute in the SDP string for SSLTCP. This results in some conflicts with Jitsi / ICE4J.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants