Sc 19672 create a tool to generate teams from GitHub part3 #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request has been linked to Shortcut Story #19672: Create a tool to generate TEAMS from Github topics. |
…rt2' into sc-19672-create-a-tool-to-generate-teams-from-github-part3
k-shlomi
changed the base branch from
sc-19672-create-a-tool-to-generate-teams-from-github-part2
to
main
Codecov Report
@@ Coverage Diff @@
## main #3 +/- ##
===========================================
+ Coverage 70.93% 87.54% +16.61%
===========================================
Files 6 7 +1
Lines 258 289 +31
===========================================
+ Hits 183 253 +70
+ Misses 75 36 -39
|
eyaliyahu
reviewed
Aug 23, 2023
src/scripts/create_teams.py
Outdated
| add_teams_to_asset(token, asset, teams_to_update) | ||
| else: | ||
| if asset.tags and "team" in [t.name for t in asset.tags]: |
There was a problem hiding this comment.
Suggested change
| if asset.tags and "team" in [t.name for t in asset.tags]: | |
| asset_has_teams_tag = asset.tags and "team" in [t.name for t in asset.tags] | |
| if asset_has_teams_tag: |
src/scripts/create_teams.py
Outdated
| for team in organization.teams: | ||
| team_resources = [] | ||
| for resource in team.resources: | ||
| if resource.type == "github_repo" and resource.name in [asset.asset_name for asset in assets]: |
There was a problem hiding this comment.
Please move "github_repo" to Enum
src/shared/clients/jit.py
Outdated
| @@ -109,7 +96,7 @@ def delete_teams(token, team_names): | |||
| break | |||
|
|
|||
| if team_id: | |||
| url = f"{JIT_API_ENDPOINT}/teams/{team_id}" | |||
| url = f"{os.getenv('JIT_API_ENDPOINT', JIT_DEFAULT_API_ENDPOINT)}/teams/{team_id}" | |||
There was a problem hiding this comment.
please move os.getenv('JIT_API_ENDPOINT', JIT_DEFAULT_API_ENDPOINT) to a small util func
eyaliyahu
approved these changes
Aug 23, 2023
k-shlomi
deleted the
sc-19672-create-a-tool-to-generate-teams-from-github-part3
branch
![jit-ci[bot]](https://avatars.githubusercontent.com/in/142441?s=60&v=4){kind=small}
There was a problem hiding this comment.
❌ The following Jit checks failed to run:
- static-code-analysis-python-semgrep
#jit_bypass_commit in this PR to bypass, Jit Admin privileges required.
More info in the Jit platform.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
sc-19672
In this PR: