Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump the expo-managed group across 1 directory with 10 updates #1935

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Oct 16, 2024

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore <dependency name> major version will close this group update PR and stop Dependabot creating any more for the specific dependency's major version (unless you unignore this specific dependency's major version or upgrade to it yourself)
  • @dependabot ignore <dependency name> minor version will close this group update PR and stop Dependabot creating any more for the specific dependency's minor version (unless you unignore this specific dependency's minor version or upgrade to it yourself)
  • @dependabot ignore <dependency name> will close this group update PR and stop Dependabot creating any more for the specific dependency (unless you unignore this specific dependency or upgrade to it yourself)
  • @dependabot unignore <dependency name> will remove all of the ignore conditions of the specified dependency
  • @dependabot unignore <dependency name> <ignore condition> will remove the ignore condition of the specified dependency and ignore conditions

@dependabot dependabot bot added dependencies Pull requests that update a dependency file javascript Pull requests that update Javascript code labels Oct 16, 2024
@dependabot dependabot bot force-pushed the dependabot/npm_and_yarn/generators/react-native/resources/expo/expo-managed-086d6592dd branch 2 times, most recently from 6cddd03 to 4799aa4 Compare October 16, 2024 19:23
@mraible
Copy link
Contributor

mraible commented Oct 17, 2024

@mshima The lint-and-test workflow is failing with the following error:

Skipped checking dependencies: expo. These dependencies are listed in expo.install.exclude in package.json. Learn more: https://expo.dev/more/expo-cli/#configuring-dependency-validation
The following packages should be updated for best compatibility with the installed expo version:
  @react-native-async-storage/[email protected] - expected version: 1.23.1
  @react-native-community/[email protected] - expected version: 8.0.1
  @react-native-picker/[email protected] - expected version: 2.7.5
  [email protected] - expected version: ~2.16.1
  [email protected] - expected version: ~3.10.1
  [email protected] - expected version: 4.10.5
  [email protected] - expected version: 3.31.1
Your project may not work correctly until you install the expected versions of the packages.

I could manually update these, but this seems like something dependabot should handle.

---
updated-dependencies:
- dependency-name: "@react-native-async-storage/async-storage"
  dependency-type: direct:production
  update-type: version-update:semver-major
  dependency-group: expo-managed
- dependency-name: "@react-native-community/datetimepicker"
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: expo-managed
- dependency-name: "@react-native-picker/picker"
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: expo-managed
- dependency-name: expo-image-picker
  dependency-type: direct:production
  dependency-group: expo-managed
- dependency-name: expo-splash-screen
  dependency-type: direct:production
  dependency-group: expo-managed
- dependency-name: react-native-gesture-handler
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: expo-managed
- dependency-name: react-native-reanimated
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: expo-managed
- dependency-name: react-native-safe-area-context
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: expo-managed
- dependency-name: react-native-screens
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: expo-managed
- dependency-name: jest-expo
  dependency-type: direct:development
  dependency-group: expo-managed
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot dependabot bot force-pushed the dependabot/npm_and_yarn/generators/react-native/resources/expo/expo-managed-086d6592dd branch from 4799aa4 to 5f94624 Compare October 17, 2024 07:59
@mshima
Copy link
Member

mshima commented Oct 17, 2024

@mraible expo validates if dependencies matches the supported ones.
We can ignore theses dependencies in dependabot or keep as reference only.

@mraible
Copy link
Contributor

mraible commented Oct 17, 2024

@mshima What do you think is the best way to get this PR to pass CI?

@mshima
Copy link
Member

mshima commented Oct 17, 2024

@mraible do you think we should ignore expo dependency check?

@mraible
Copy link
Contributor

mraible commented Oct 17, 2024

I don't think we should ignore it. I get the feeling that it's there for a reason.

@mshima
Copy link
Member

mshima commented Oct 17, 2024

I don't think we should ignore it. I get the feeling that it's there for a reason.

So this PR should be ignored.
These dependencies are updated by running npx expo install --fix in the expo folder when expo has a new version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file javascript Pull requests that update Javascript code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants