Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

D11 testing and fixes #276

Merged
merged 11 commits into from
Jul 31, 2024
Merged

D11 testing and fixes #276

merged 11 commits into from
Jul 31, 2024

Conversation

Berdir
Copy link
Contributor

@Berdir Berdir commented Jul 29, 2024

No description provided.

@Berdir
Copy link
Contributor Author

Berdir commented Jul 29, 2024

Trying to support such a far range of versions is getting more and more challenging.

  • Removed drupal-check, no longer really recommended and doesn't yet support symfony 7, phpstan should be setup directly, but no idea if that works for non-modules anyway, it certainly didn't find user_role_names(). Setting up phpstan seems out of scope.
  • phpspec somehow doesn't seem to have a compatible version for PHP 8.1, so dropped combinations with that. In general, switched from exclude to including a few specific combinations only. too many invalid combinations now.
  • phpunit 10 is necessary for D11, requires some changes to test classes and making the data provider abstract. Apart from the drush driver test, the only test is Drupal 7 field value stuff, but Drupal 7 isn't supported anymore.

@jhedstrom jhedstrom merged commit 5a92b22 into jhedstrom:master Jul 31, 2024
4 checks passed
@jhedstrom
Copy link
Owner

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants