Remove Ant scripts and move to Maven only #243
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* We create a dedicated profile to generate the manual. We still rely on AntRun plugin; We manipulate the versions here to use on JDK 18+. * We use the surefire report plugin to replace the reports task; * Update the CI script to generate the reports and upload; * Update the scripts to use only the Maven build.
|
OK, the action is working. Once we have a test failure, we check if the report generation and upload steps are correct. |
|
At some point it would be nice to have a maven only build of the manual, rather than having to use ant-run. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am opening a PR because of the changes to the action script so it can run before merging.
We have roughly equivalents of the previous tasks.
Use
mvn clean compile -Pmanualto generate the manual. This will not run the tests by default.Use
mvn surefire-report:report-onlyto generate the report after running the tests. This uses the surefire-plugin, so the HTML looks different. The other option would be to utilize AntRun and add the jar for thejunitreporttask.I also updated the scripts to default to the Maven build, and the GH action script to generate and upload the reports in case of test failures.
Closes #242.