Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check if supplied FORMAT matches with an HTML slide deck value. Return True for isRawHtml. #9110

Merged
merged 2 commits into from
Sep 29, 2023
Merged

Check if supplied FORMAT matches with an HTML slide deck value. Return True for isRawHtml. #9110

merged 2 commits into from
Sep 29, 2023

Conversation

coatless
Copy link
Contributor

This PR attempts to close out the HTML writer portion of #8880.

The change implement seeks to check whether f is part of the supported HTML slide formats. Thus, if we have a code block in revealjs of:

```{=revealjs}
Hello there!
```

The text will be retained and treated as raw in the output format, e.g.

Hello there!

Presently, the text will be deleted in the output, e.g.

We've supplied a sample test document.

If this is okay, we can submit a follow-up PR to address the EPUB issue or add it into this PR.

Test Markdown Document
---
title: Test HTML Raw Fix
author: JJB
date: Sept 29, 2023
---

# Test Slide Format Retention

```{=revealjs}
Retain this text as we're under `revealjs`
```

```{=s5}
Retain this text as we're under `s5`
```

```{=slidy}
Retain this text as we're under slidy
```

```{=slideous}
Retain this text as we're under slideous
```

```{=dzslides}
Retain this text as we're under dzslides
```

# Verify HTML content is retained

```{=html}
Retain Hard `html` tag content
```

```{=html4}
Retain Hard `html4` tag content
```

```{=html5}
Retain Hard `html5` tag content
```

# Verify LaTeX via MathJax is okay

Verify we're okay with Math/LaTeX blocks.

$1 + 1$

# Check other raw block formats do not come through

There should be no warning after this ... 

```{=toad}
WARNING CONTENT WAS NOT DROPPED 
```

@coatless
Copy link
Contributor Author

Note, the CI linux stack failure is related to the prior dependency update that was committed into the master branch earlier today.

Dependency up issue:
2c6f22d

CI Noting the dependency:
https://github.com/jgm/pandoc/actions/runs/6333279364/job/17201158316?pr=9110#step:6:26

@dlsun
Copy link

dlsun commented Sep 28, 2023

I just wanted to signal-boost this pull request, as it is blocking coatless/quarto-webr#14, which would be really useful for my teaching!

@jgm jgm merged commit 4d11ea7 into jgm:main Sep 29, 2023
9 of 12 checks passed
@jgm
Copy link
Owner

jgm commented Sep 29, 2023

thanks!

@coatless coatless deleted the fix-raw-block-html branch September 30, 2023 19:32
@dlsun
Copy link

dlsun commented Oct 2, 2023

This patch is needed to make WebR usable in slides coatless/quarto-webr#14. A number of us are trying to use this in our classes right now, so we are eagerly awaiting the next point release of Pandoc so that this patch can be incorporated into Quarto. Is there an ETA on the next release?

@jgm
Copy link
Owner

jgm commented Oct 2, 2023

No specific ETA, no. But you should be able to work around this issue by specifying {=html} in the slide decks.

@coatless
Copy link
Contributor Author

coatless commented Oct 2, 2023

@jgm unfortunately, we're locked with supplying {=revealjs} due to Quarto c.f. initial discussion by @cderv in #8880. Based on the previous release cadence, wouldn't you aim for a new release on the 8th of October or so?

@jgm
Copy link
Owner

jgm commented Oct 2, 2023

The previous quick release cadence was because I prioritize fixing regressions.

@coatless
Copy link
Contributor Author

coatless commented Oct 2, 2023

Ah, well whenever you have an opportunity, it would be great to get a new point release.

No rush as we'll have to update the included copy of pandoc in Quarto.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants