Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Let Lex generator return the number of minimized states #684

Merged
merged 10 commits into from
Dec 14, 2019
Merged

Let Lex generator return the number of minimized states #684

merged 10 commits into from
Dec 14, 2019

Conversation

regisd
Copy link
Member

@regisd regisd commented Dec 12, 2019 •
edited
Loading

Add assertion about the number of minimized DFA states.
See also #679

@regisd regisd requested a review from lsf37 as a code owner December 12, 2019 22:20
@regisd regisd self-assigned this Dec 12, 2019
lsf37
lsf37 reviewed Dec 12, 2019
View reviewed changes
Copy link
Member

@lsf37 lsf37 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, this looks like it's going into the right direction. It might be possible to reduce the number of minised = false assignments, but I can have a deeper look at that afterwards.

I'll be offline for a few days, feel free to go ahead on these.

@regisd regisd merged commit 263c2e4 into jflex-de:master Dec 14, 2019
@regisd regisd deleted the lexgenerator branch December 14, 2019 01:08
regisd pushed a commit that referenced this pull request Dec 14, 2019
@traviscibot
Pseudo-Merge 263c2e4 Let Lex generator return the number of minimized…
9c64e0a 
… states (#684)

commit 263c2e4
Author:     Régis Décamps <[email protected]>
AuthorDate: Sat Dec 14 02:08:22 2019 +0100
Commit:     GitHub <[email protected]>
CommitDate: Sat Dec 14 02:08:22 2019 +0100

    Let Lex generator return the number of minimized states (#684)

    * Make LexGenerator non-static

    * LexGenerator returns the number of minimized DFA states

    * Make DFA.minimize() no-op if it's already minimized.

    * Add expectation about nb of DFA states in JFlexTestGenerator

Updated from target/jflex-parent-1.8.0-SNAPSHOT-sources.jar
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lsf37 lsf37 lsf37 left review comments

Assignees

@regisd regisd

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@regisd @lsf37