Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Options and Out thread-safe. #258

Closed
wants to merge 80 commits into from
Closed

Make Options and Out thread-safe. #258

wants to merge 80 commits into from

Commits on Nov 11, 2017

  1. Make Options and Out thread-safe.

    - Split Main in 2 classes
      - Main the cli client
      - LexGenerator that generates java code
    - Replace manual command line parsing by commons-cli
    - Replace Options by GeneratorOptions, an immutable object
    - Remove all statics from Out
      - Deleted dead DEBUG statements
      - Throws exceptions when possible (which removes a few dependencies on this Out logger)
      - Also simplify error formatting with varaargs
    - Update maven-jflex-plugin
    - To reduce scope on this XL change:
      - Move anttask in a separate directory. Build broken, even though mostly update. TODO: Make it compile as a POM.
      - Move GUI in a separate directory. Build broken. TODO: Make it compile as a POM.
      - testsuite-maven-plugin build broken. Renamed Main to Tester to avoid confusion with jflex.Main.
    regisd committed Nov 11, 2017
    Configuration menu
    Copy the full SHA
    9c36a45 View commit details
    Browse the repository at this point in the history

Commits on Nov 13, 2017

  1. Revert Options.DEBUG blocks

    regisd committed Nov 13, 2017
    Configuration menu
    Copy the full SHA
    d4be759 View commit details
    Browse the repository at this point in the history
  2. Revert commons-cli

    regisd committed Nov 13, 2017
    Configuration menu
    Copy the full SHA
    1575f09 View commit details
    Browse the repository at this point in the history

Commits on Aug 31, 2018

  1. Merge branch 'master' into multithread

    # Conflicts:
    #	jflex-maven-plugin/src/main/java/de/jflex/plugin/maven/JFlexMojo.java
    #	jflex/pom.xml
    #	testsuite/jflex-testsuite-maven-plugin/src/main/java/jflextest/Exec.java
    #	testsuite/jflex-testsuite-maven-plugin/src/main/java/jflextest/JFlexTestsuiteMojo.java
    #	testsuite/jflex-testsuite-maven-plugin/src/main/java/jflextest/TestCase.java
    regisd committed Aug 31, 2018
    Configuration menu
    Copy the full SHA
    0d905d2 View commit details
    Browse the repository at this point in the history
  2. Fix NPE

    regisd committed Aug 31, 2018
    Configuration menu
    Copy the full SHA
    25e5f67 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    3d96cb2 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    52cc713 View commit details
    Browse the repository at this point in the history
  5. Fix testsuite

    regisd committed Aug 31, 2018
    Configuration menu
    Copy the full SHA
    983ea40 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    08e03e8 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    39977a1 View commit details
    Browse the repository at this point in the history

Commits on Sep 2, 2018

  1. Configuration menu
    Copy the full SHA
    2f3dfc2 View commit details
    Browse the repository at this point in the history
  2. Remove dep on AutoValue

    regisd committed Sep 2, 2018
    Configuration menu
    Copy the full SHA
    a9aac43 View commit details
    Browse the repository at this point in the history
  3. Don't use optional

    regisd committed Sep 2, 2018
    Configuration menu
    Copy the full SHA
    82d6a92 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    6500a41 View commit details
    Browse the repository at this point in the history
  5. Update GUI

    regisd committed Sep 2, 2018
    Configuration menu
    Copy the full SHA
    5287525 View commit details
    Browse the repository at this point in the history

Commits on Sep 3, 2018

  1. Update mojo

    regisd committed Sep 3, 2018
    Configuration menu
    Copy the full SHA
    288810e View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    8949ed4 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    7c2ead3 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    7f9ffa2 View commit details
    Browse the repository at this point in the history
  5. delete pom for anttask

    regisd committed Sep 3, 2018
    Configuration menu
    Copy the full SHA
    f304e61 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    0c5bc38 View commit details
    Browse the repository at this point in the history
  7. restore commented code

    regisd committed Sep 3, 2018
    Configuration menu
    Copy the full SHA
    22c2902 View commit details
    Browse the repository at this point in the history

Commits on Sep 4, 2018

  1. Revert minor changes

    regisd committed Sep 4, 2018
    Configuration menu
    Copy the full SHA
    e476a01 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    484abcd View commit details
    Browse the repository at this point in the history
  3. Reformat code

    regisd committed Sep 4, 2018
    Configuration menu
    Copy the full SHA
    d10c773 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    077722a View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    55efca0 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    47f9318 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    c234c1e View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    2e5e93f View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    e001c49 View commit details
    Browse the repository at this point in the history
  10. Configuration menu
    Copy the full SHA
    1decb26 View commit details
    Browse the repository at this point in the history

Commits on Sep 6, 2018

  1. Configuration menu
    Copy the full SHA
    07663a9 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    fd68165 View commit details
    Browse the repository at this point in the history
  3. Extract method checkOutput

    regisd committed Sep 6, 2018
    Configuration menu
    Copy the full SHA
    701e1ba View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    dc2ad3d View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    3dc453a View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    6d6deb9 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    cf0e10f View commit details
    Browse the repository at this point in the history
  8. Correctly pass options to jflex in jflex-testsuite-maven-plugin

    I was setting default options, which caused tests with an expected dump to fail
    regisd committed Sep 6, 2018
    Configuration menu
    Copy the full SHA
    5188712 View commit details
    Browse the repository at this point in the history
  9. Improve error message in regression test cases

        - show the full path of the expected file
        - output the actual output in a file in case of failure
    regisd committed Sep 6, 2018
    Configuration menu
    Copy the full SHA
    08b88a2 View commit details
    Browse the repository at this point in the history
  10. Configuration menu
    Copy the full SHA
    bfc0c09 View commit details
    Browse the repository at this point in the history

Commits on Sep 8, 2018

  1. Regression tests: fix six-digit-unicode-escape

    Throw the scanner exception directly when there is one [rather than wrapping in genrator exception]
    regisd committed Sep 8, 2018
    Configuration menu
    Copy the full SHA
    44e99f4 View commit details
    Browse the repository at this point in the history
  2. Regression tests: fix semcheck

    Throw the GeneratorExcption directly rather than wrapping it inside a new GeneratorException
    regisd committed Sep 8, 2018
    Configuration menu
    Copy the full SHA
    252bcf3 View commit details
    Browse the repository at this point in the history
  3. Regressions: fix ccl-esc

    Restore log of "Writing code in Emitter ctor"
    But do it in LexGenerator, raher than Emitter ctor.
    Move Emitter.normalize() to LexGenerator.
    regisd committed Sep 8, 2018
    Configuration menu
    Copy the full SHA
    8c6256d View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    31c5672 View commit details
    Browse the repository at this point in the history
  5. Format code

    regisd committed Sep 8, 2018
    Configuration menu
    Copy the full SHA
    c2c4fe5 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    6a931f9 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    e11a78f View commit details
    Browse the repository at this point in the history
  8. Also catch MacrosException

    Regressions: fix macro-exp2
    regisd committed Sep 8, 2018
    Configuration menu
    Copy the full SHA
    62f813c View commit details
    Browse the repository at this point in the history
  9. Regressions: fix java

    Out has been renamed log
    regisd committed Sep 8, 2018
    Configuration menu
    Copy the full SHA
    459a78a View commit details
    Browse the repository at this point in the history
  10. Regressions test: Construct TestFailure with the output

    This is how it was done before.
    regisd committed Sep 8, 2018
    Configuration menu
    Copy the full SHA
    cfdd4a0 View commit details
    Browse the repository at this point in the history
  11. Configuration menu
    Copy the full SHA
    e35c7ef View commit details
    Browse the repository at this point in the history
  12. Configuration menu
    Copy the full SHA
    ea97f94 View commit details
    Browse the repository at this point in the history
  13. Configuration menu
    Copy the full SHA
    1d36f18 View commit details
    Browse the repository at this point in the history
  14. Use the same logger for the scanner

    Fix regressions tests not detecting scanner generation logs, such as "Including [file]"
    regisd committed Sep 8, 2018
    Configuration menu
    Copy the full SHA
    6a0cec1 View commit details
    Browse the repository at this point in the history
  15. Correctly catch MacroException

    Fix regressions macro-exp2
    regisd committed Sep 8, 2018
    Configuration menu
    Copy the full SHA
    b292412 View commit details
    Browse the repository at this point in the history
  16. Configuration menu
    Copy the full SHA
    4511a91 View commit details
    Browse the repository at this point in the history
  17. Regressions: Fix golden file for java

    There are still some usages of Out
    regisd committed Sep 8, 2018
    Configuration menu
    Copy the full SHA
    b4f5b2a View commit details
    Browse the repository at this point in the history
  18. Fix parsing --no-warn-unused

    regisd committed Sep 8, 2018
    Configuration menu
    Copy the full SHA
    a240fa0 View commit details
    Browse the repository at this point in the history
  19. Configuration menu
    Copy the full SHA
    a77a4cc View commit details
    Browse the repository at this point in the history
  20. Reformat code

    regisd committed Sep 8, 2018
    Configuration menu
    Copy the full SHA
    65f4459 View commit details
    Browse the repository at this point in the history

Commits on Sep 16, 2018

  1. Configuration menu
    Copy the full SHA
    e2d362a View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    116c378 View commit details
    Browse the repository at this point in the history

Commits on Sep 21, 2018

  1. Configuration menu
    Copy the full SHA
    106b7e6 View commit details
    Browse the repository at this point in the history

Commits on Sep 22, 2018

  1. Configuration menu
    Copy the full SHA
    fbb98e8 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    991a64c View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    cb4fd5b View commit details
    Browse the repository at this point in the history

Commits on Sep 29, 2018

  1. Configuration menu
    Copy the full SHA
    6547eba View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    694646e View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    370f7a1 View commit details
    Browse the repository at this point in the history

Commits on Sep 30, 2018

  1. Configuration menu
    Copy the full SHA
    d946985 View commit details
    Browse the repository at this point in the history
  2. typo

    regisd committed Sep 30, 2018
    Configuration menu
    Copy the full SHA
    443a8fb View commit details
    Browse the repository at this point in the history

Commits on Oct 2, 2018

  1. Configuration menu
    Copy the full SHA
    cc85a70 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    5eec36a View commit details
    Browse the repository at this point in the history

Commits on Oct 7, 2018

  1. Merge branch 'master' into multithread

    Not compiled / not tested
    regisd committed Oct 7, 2018
    Configuration menu
    Copy the full SHA
    0730438 View commit details
    Browse the repository at this point in the history

Commits on Oct 10, 2018

  1. Configuration menu
    Copy the full SHA
    50843a3 View commit details
    Browse the repository at this point in the history

Commits on Oct 21, 2018

  1. Configuration menu
    Copy the full SHA
    a37349e View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    3260e11 View commit details
    Browse the repository at this point in the history
  3. Merge with master

    regisd committed Oct 21, 2018
    Configuration menu
    Copy the full SHA
    197caa0 View commit details
    Browse the repository at this point in the history