-
Notifications
You must be signed in to change notification settings - Fork 215
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature: Update to JSON Plugin Schema to Support Private Plugin Sources #2470
Open
Bee-Mar
wants to merge
48
commits into
jetify-com:main
Choose a base branch
from
Bee-Mar:feature/json-plugin-schema
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+1,544
−519
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ure/gitlab-plugins
…ure/gitlab-plugins
…ure/json-plugin-schema
…ure/json-plugin-schema
… handle subgroups from gitlab
…ure/json-plugin-schema
…ure/json-plugin-schema
Bee-Mar
changed the title
Feature: Update to JSON Plugin Schema to Allow Private Sources
Feature: Update to JSON Plugin Schema to Support Private Plugin Sources
Dec 22, 2024
Signed-off-by: Brandon Marlowe <[email protected]>
…x into feature/json-plugin-schema
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The pull request introduces the ability to add plugins from private sources, which includes GitHub, GitLab, Bitbucket and arbitrary hosts. The JSON schema was reworked to be more declarative, which forces the user declare components of the addressed location. Changing the structure allows for future flexibility, and was needed in my case when working with repositories only accessible through an AWS tunnel. While it does make the
include
section more verbose, I believe the verbosity is a positive.In short, the plugin declaration syntax goes from something like this:
to
An example of privately hosted plugins accessible through SSH:
How was it tested?
New unit tests were added to
internal/plugin/git_test.go
, and this has been tested in by creating several repos to use as a test-bed, and ensuring they can be installed by declaring them in thedevbox.json
. Additionally, I have used this for my desired purpose, which is to access Devbox plugins only accessible in a privately hosted GitLab repo behind an AWS tunnel.Addtional unit tests can be added if preferred. Please let me know what changes/improvements you'd like to see.
Thank you in advance for taking the time to review my pull request!