Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[clean] Add clean command #2347

Closed
wants to merge 1 commit into from
Closed

[clean] Add clean command #2347

wants to merge 1 commit into from

Conversation

mikeland73
Copy link
Contributor

@mikeland73 mikeland73 commented Oct 10, 2024

Summary

fixes #2341

Edit:

fixes #2335 but closed as duplicate to #2341

How was it tested?

@mikeland73 mikeland73 requested review from savil and Lagoja October 10, 2024 21:53
@DerArkeN
Copy link
Contributor

I am a little confused about 2 PRs for the same thing being open at once, also I don't know what this "fixes".
I also noticed this will delete the config file again, which we discussed not to delete for the default behavior.
Shouldn't we keep the discussion at one single point instead of working on the same thing in parallel?

@mikeland73
Copy link
Contributor Author

@DerArkeN sorry about this, I hadn't see your PR and drafted this change when I saw a comment from @Lagoja. I'll close this and focus on your PR instead.

Also, my description was careless and wrong. What I meant to write was "fixes #2335" which causes github to associate the PR to the issue. I somehow copied your PR and linked to it instead.

@mikeland73 mikeland73 closed this Oct 15, 2024
@mikeland73 mikeland73 deleted the landau/clean-command branch October 15, 2024 20:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Add a clean command to inverse devbox init
2 participants