Migrate from pm2-logrotate to @jessety/pm2-logrotate
#33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`pm2-logrotate` is unmaintained, and has had a critical issue on Windows for a long time now.
|
Thank you, much appreciated! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
pm2-logrotatehas been unmaintained since 2019, and has had a critical issue on Windows for a long time now where the older log files simply would not be deleted. @jessety/pm2-logrotate is a new fork that corrects that issue.Type
Fixes bugs. See:
keymetrics/pm2-logrotate#170
keymetrics/pm2-logrotate#169
Logrotate doesn't seem to have any other viable forks at the moment. See:
keymetrics/pm2-logrotate#173
Testing
Tested on Windows 10 Pro and Server 2016.