Update cppcheck #5108
Merged
Update cppcheck #5108
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akosthekiss
requested changes
Nov 15, 2023
jerry-ext/util/sources.c
Outdated
| if (tmp == NULL) { | ||
| return jerry_throw_sz(JERRY_ERROR_COMMON, "Out of memory."); | ||
| } | ||
| source_p = tmp; |
There was a problem hiding this comment.
is a new temporary needed? why not simply
source_p = realloc (source_p, new_size);
if (source_p == NULL) {
return jerry_throw_sz(JERRY_ERROR_COMMON, "Out of memory.");
}?
jerry-port/common/jerry-port-io.c
Outdated
| { | ||
| jerry_port_fatal (JERRY_FATAL_OUT_OF_MEMORY); | ||
| } | ||
| line_p = tmp; |
There was a problem hiding this comment.
same here.
line_p = realloc (line_p, allocated);
if (line_p == NULL)
{
jerry_port_fatal (JERRY_FATAL_OUT_OF_MEMORY);
}?
tests/unit-core/test-api.c
Outdated
| jerry_value_t handler = jerry_object (); | ||
| jerry_value_t proxy = jerry_proxy (target, handler); | ||
| jerry_value_t handler_ = jerry_object (); | ||
| jerry_value_t proxy = jerry_proxy (target, handler_); |
There was a problem hiding this comment.
this isn't nice. what is the problem of cppcheck with handler?
There was a problem hiding this comment.
The problem was that is shadowed the handler function defined at line 64.
I agree its not a good name, it was just a placeholder.
matetokodi
force-pushed
the
update_cppcheck
branch
2 times, most recently
from
32c4f76
to
f7182d7
Compare
matetokodi
force-pushed
the
update_cppcheck
branch
3 times, most recently
from
df7afee
to
901a7af
Compare
Re-enable cppcheck CI job
Update cppcheck suppression list:
The new version of cppcheck raises warnings for many potential
issues that are guarded against, so those warnings have been
supressed.
Handle realloc failures:
- jerry-ext/util/sources.c
- jerry-port/common/jerry-port-io.c
Refactor test-snapshot: move each test to separate functions like some
others already were.
Rename `handler` variables inside `main` of `test-api.c` as they
shadowed the `handler` function in the same file.
JerryScript-DCO-1.0-Signed-off-by: Máté Tokodi [email protected]
matetokodi
force-pushed
the
update_cppcheck
branch
from
901a7af
to
fbaa908
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch depends on #5106
Once that is merged, this patch will be rebased on only include the cppcheck commit.
In this patch:
The new version of cppcheck raises warnings for many potential
issues that are guarded against, so those warnings have been
supressed.
jerry-ext/util/sources.cjerry-port/common/jerry-port-io.c