Upgrading according to latest three.js version #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hello! First of all, let me say many many thanks for your effort to develop this, to my taste, nifty piece of code for using webaudio together with three.js! It makes it much easier for me to start with audio in 3D during my own efforts in three.js construction works. What I in this little fork just did is; Replaced every appearance of the method name .getPositionFromMatrix() with .setFromMatrixPosition(). Actually, I am not sure, if you already before may have considered upgrading the otherwise deprecated function name to the new one? It only creates a warning message, and sure enough, remaining with the old function name users of the script, who stick to the older three.js versions can keep using it. I am still new to the question of maintaining scripts, therefore only in case you did not notice the deprecation issue, and not having gauged the benefits and the drawbacks yourself, yet, I consider it may be of relevance. The more so, I feel encouraged to propose this to you, as I could see that the according method has been renamed in case of your other scripts threex.transparency.js and threex.objcoord.js as well. And as I like to keep in mind always Winnie the Pooh while continuing some construction work with the coding ... http://orig01.deviantart.net/8db6/f/2011/049/8/5/winnie_the_pooh_by_jo_from_kokomo-d39toyl.jpg Regards Robert
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello!
First of all, let me say many many thanks for your effort to develop this, to my taste, nifty piece of code for using webaudio together with three.js! It makes it much easier for me to start with audio in 3D during my own efforts in three.js construction works.
What I in this little fork just did is; Replaced every appearance of the method name .getPositionFromMatrix() with .setFromMatrixPosition().
Actually, I am not sure, if you already before may have considered upgrading the otherwise deprecated method name to the new one? It only creates a warning message, and sure enough, remaining with the old method name users of the script, who stick to the older three.js versions can keep using it. I am still new to the question of maintaining scripts, therefore only in case you did not notice the deprecation issue, and not having gauged the benefits and the drawbacks yourself, yet, I consider it may be of relevance. The more so, I feel encouraged to propose this to you, as I could see that the according method has been renamed in case of your other scripts threex.transparency.js and threex.objcoord.js as well.
And as I like to keep in mind always Winnie the Pooh while continuing some construction work with the coding ... http://orig01.deviantart.net/8db6/f/2011/049/8/5/winnie_the_pooh_by_jo_from_kokomo-d39toyl.jpg
Regards
Robert