[JENKINS-6415] fail on external error

[domruf]

I believe an error while handling externals should fail the build. see JENKINS-6415

[buildhive]

Jenkins » subversion-plugin #188 UNSTABLE
Looks like there's a problem with this pull request
(what's this?)

[jenkinsadmin]

Thank you for a pull request! Please check this document for how the Jenkins project handles pull requests

[domruf]

a svn test repository seems to be down
therefore a test fails

[kutzi]

Thanks for the PR.
Sorry that this was left without attention for so long.

Can you created a regression test case for the change? https://wiki.jenkins-ci.org/display/JENKINS/Unit+Test

[oleg-nenashev]

The PR stills actual. It would worth to merge it

[recena]

@oleg-nenashev I'll review the bug and the solution. I've assigned myself this ticket JENKINS-6415

[mastier]

Hi, any progress on that ?

[recena]

@mastier Soon.

[mastier]

your last response was 7 months ago :-) I hope "soon", it does not mean
next half-year. What stops you from merging it (it merges cleanly) ? You
prefer implementing it as an optional "tick" ? "Fail on external builds".

2016-02-22 13:27 GMT+01:00 Manuel Recena [email protected]:

@mastier https://github.com/mastier Soon.

—
Reply to this email directly or view it on GitHub
#50 (comment)
.

Kind regards,
Bartosz Woronicz

[recena]

@mastier Maybe because I was working on 7 revisions of this plugin 😵

[mastier]

Ok, I thought it was quite important fix and easy to introduce... Do not feel like I am pushing, because I am not.

[mastier]

I see that doesn't not compile anymore, 'cause there were changes in SVNkit api. Would you advice me how to fix just for myself ?

What replaces getExternalInfo() in the current API ?
http://svnkit.com/javadoc/

i.e. here:
String msg = String.format("Error handling external %s to url %s", event.getExternalInfo().getPath(), event.getExternalInfo().getUnresolvedUrl());

SVNEvent object event does not have method like getExternalInfo()

I asked the same also on the SVNkit mailing list.
http://subversion.1072662.n5.nabble.com/getExternalInfo-in-SVNEvent-in-current-API-td196210.html

[opomuc]

Hi, @recena
We faced same issue in our project. I was glad to find a fix here, thank you for that.
Will try to compile plugin version with the fix myself, but...
It would be great to have it in latest, wouldn't it?

@mastier Any update on the issue?

[opomuc]

@recena @jenkinsadmin
Hi! Still waiting for the response on the issue. It has been a known bug for over 6 years already!!

[winotu]

Bump !

[jglick]

No test, not likely to get much attention.

[kuisathaverat]

related to #204