WIP Re-enable accidentially disabled integration tests #124
Conversation
darxriggs
force-pushed
the
fix-disabled-integration-tests
branch
3 times, most recently
from
38d12bf
to
12af05c
Compare
The culprit is commit 9580862 when switching from HudsonTestCase to JenkinsRule. The rule has to be used as a JUnit 4 rule inside a test. It is different to JUnit 3 and cannot be used as a base class. As no JUnit 3 base class is used anymore the JUnit 4 runner kicks in and only detects methods annotated with `@Test` as test methods. JUnit 3 was using the prefix "test" in method names to detect test methods. The temporary folder has to be provided as absolute path. Otherwise `Jenkins::checkRawBuildsDir` fails with a message like this: "jenkins.model.InvalidBuildsDir: ${ITEM_ROOTDIR}/builds does not resolve to an absolute path" `WebClient::goTo` now takes a relative instead of an absolute URL. Triggering the "change" event on HTML form inputs now requires a bit more plumbing. Many tests fail because running the Javascript code fails reporting a missing "each" function.
darxriggs
force-pushed
the
fix-disabled-integration-tests
branch
from
12af05c
to
6da487e
Compare
…m. Fix a bug with hide version changes label not being displayed.
|
@NotMyFault Maybe you are interested in activating these integration tests again. I am not planning to continue on this PR. It think there is still quite some work to do:
|
To be fair, I didn't look much into tests yet, considering this plugin uses fairly dated dependencies, especially for tests, see mockito 1.10 for example (or the other failing dependabot prs). |
The culprit is commit 9580862 when switching from HudsonTestCase to JenkinsRule. The rule has to be used as a JUnit 4 rule inside a test. It is different to JUnit 3 and cannot be used as a base class. As no JUnit 3 base class is used anymore the JUnit 4 runner kicks in and only detects methods annotated with
@Testas test methods. JUnit 3 was using the prefix "test" in method names to detect test methods.The temporary folder has to be provided as absolute path. Otherwise
Jenkins.checkRawBuildsDirfails with a message like this:"jenkins.model.InvalidBuildsDir: ${ITEM_ROOTDIR}/builds does not resolve to an absolute path"
Many tests still fail because running the Javascript code fails reporting a missing "each" function.
TODO
Can you please have a look at the failing tests and provide further information on how to fix these or even add commits for it?